Improves build time by 30%, resolving issue 5123 "Charts Framework takes a long time to build" #5124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves issue ChartsOrg#5123 "Charts framework takes a long time to build" (ChartsOrg#5123) by implementing the recommendations listed at the end of the issue: - Set `Eager Linking` build setting to `Yes` for `Charts` framework target - Set `Enable Module Verifier` build setting to `No` for `Debug` builds - Set `Compilation Mode` to `Incremental` for `Debug` builds - Add `-Xfrontend -warn-long-expression-type-checking=50` (or perhaps use `100`) to `OTHER_SWIFT_FLAGS` so the Swift compiler will emit warnings for expressions that take a long time to type-check. The number after the = is the number of milliseconds threshold, above which warnings will be emitted. - Refactored the slow type-checking hotspots identified above in `ChartAnimationEasing.swift`, breaking out expressions which are slow to type-check into separate, quicker-to-type-check expressions.
drewster99
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #5123 "Charts framework takes a long time to build" (#5123) by implementing the recommendations listed at the end of the issue. These changes improved the clean full
Debugbuild time by 30%.Issue Link 🔗
Charts framework takes a long time to build
Goals ⚽
Improves build times of the Charts framework target for both clean and incremental
Debugbuilds, enabling more parallelization during building.Implementation Details 🚧
This PR makes the following changes:
Eager Linkingbuild setting toYesforChartsframework targetEnable Module Verifierbuild setting toNoforDebugbuildsCompilation ModetoIncrementalforDebugbuilds-Xfrontend -warn-long-expression-type-checking=50(or perhaps use100) toOTHER_SWIFT_FLAGSso the Swift compiler will emit warnings for expressions that take a long time to type-check. The number after the = is the number of milliseconds threshold, above which warnings will be emitted.ChartAnimationEasing.swift, breaking out expressions which are slow to type-check into separate, quicker-to-type-check expressions.Testing Details 🔍
To test/verify the build time improvement, use these simple steps -- first with the existing code, and then again using this PR branch/commit:
rm -rf $HOME/Library/Developer/Xcode/DerivedData)