Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getBarBounds callable from Objective-C code (Fixes #570) #571

Merged
merged 1 commit into from Nov 26, 2015
Merged

Make getBarBounds callable from Objective-C code (Fixes #570) #571

merged 1 commit into from Nov 26, 2015

Conversation

ghost
Copy link

@ghost ghost commented Nov 25, 2015

Relates to #570.

Changed method return value to nonnull, because CGRect in Objective-C doesn't allow nil since it's not an object. When the bar bounds cannot be calculated because the data set is nil now the method returns CGRectNull instead of nil.
@danielgindi
Copy link
Collaborator

Seems fine to me. :-)

danielgindi added a commit that referenced this pull request Nov 26, 2015
Make getBarBounds callable from Objective-C code (Fixes #570)
@danielgindi danielgindi merged commit d6ca409 into ChartsOrg:master Nov 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants