LineChart: drawing image on nodal points [Dup #624?] #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 28, 2015 10:02
LineChardRenderer: those images are drawn same way as circles
Fixed: image now is not drawn upside down.
ghost
changed the title
ghost
mentioned this pull request
|
It seems like both you and @zmchristensen are trying to implement icons (In #624), for different charts. |
danielgindi
changed the title
|
@danielgindi: between the two implementations, do you have a preference for how icon are drawn? |
|
Not really- it just needs to be consistent as much as it can be with other APIs in the framework |
|
@zmchristensen finally I've got time to fix this issue. Which of your branches can I merge my changes with? master or chart-icons? |
|
@AnatolyRosencrantz: The chart-icons branch will be best. |
|
Feature of this PR is included in #1261 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes circle in the nodal point is not enough customisation. Here implemented add-on to LineChart renderer which allows to draw custom UIImage instead of (or on top of) circle.
For using: switch DataSet.drawNodalImageEnabled=true, set image by DataSet.nodalImage=UIImage() and that's it. See demo project also.