Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for cubic line chart fill when charts that don't start at x-index 0 #711 #712

Merged
merged 1 commit into from
Feb 23, 2016

Conversation

gunterhager
Copy link
Contributor

Fix for issue #711

Cubic line charts that don’t start at x-index 0 don’t fill correctly
because the fill starts at index 0 (Regular line charts don’t have that
issue). To correct this the index for the fill is taken from the data
entries (similar to regular line chart fill).
Ultimately i think the renderer should be refactored to use a common
code path for filling cubic and regular line charts.

…t x-index 0 (ChartsOrg#711)

Cubic line charts that don’t start at x-index 0 don’t fill correctly
because the fill starts at index 0 (Regular line charts don’t have that
issue). To correct this the index for the fill is taken from the data
entries (similar to regular line chart fill).
Ultimately i think the renderer should be refactored to use a common
code path for filling cubic and regular line charts.
@danielgindi
Copy link
Collaborator

Thank you!
I'll take a look at it soon.

About the refactoring suggested - you are right, although I'm not sure how easy this would be... There are more complex issues to solve about cubic paths, like clipping them to straight lines when going below minimum axis...

@gunterhager
Copy link
Contributor Author

I understand - yes it might be more complex than i thought. I just felt a little uneasy fixing this issue the way i did. I didn't like the smell of code duplication.

danielgindi added a commit that referenced this pull request Feb 23, 2016
Fix for cubic line chart fill when charts that don't start at x-index 0 #711
@danielgindi danielgindi merged commit 79b5ceb into ChartsOrg:master Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants