Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing iOS deployment target to 8.0 from 8.1 #74

Merged
merged 1 commit into from
May 6, 2015
Merged

Changing iOS deployment target to 8.0 from 8.1 #74

merged 1 commit into from
May 6, 2015

Conversation

michaelmcguire
Copy link

The project has an iOS Deployment Target set to 8.1 which prevented me from using in a project targeting 8.0 via Carthage. I tested the library on a device using iOS 8.0 and it seemed to work fine. In addition, the podspec specifies 8.0, so this updates the project deployment target to 8.0 from 8.1.

danielgindi added a commit that referenced this pull request May 6, 2015
Changing iOS deployment target to 8.0 from 8.1
@danielgindi danielgindi merged commit af18dca into ChartsOrg:master May 6, 2015
@pmairoldi
Copy link
Collaborator

Why was the project target changed from 8.0 to 8.1. Couldn't the iOS Deployment Target be set to 8.0 instead of 8.1?

@michaelmcguire
Copy link
Author

@petester42 You have it backwards. It used to be set to 8.1, now it is set to 8.0 (on master, at least)

@pmairoldi
Copy link
Collaborator

Oops. Ya you're right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants