-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port ios-charts to OS X. #759
Conversation
This commit adds a thin UIKit/Cocoa abstraction layer (Util/ChartsPlatform.swift). It also adds an OS X demo application.
Ah, I might have inadvertently set the target platform for the 'Charts-iOS' target to OSX. Simply changing this back to iOS should fix the test. |
…t properly exported from Swift to Objective-C, so just use the UI* classes from iOS code).
Great work! Looks good to me. I will merge this into a separate branch so that we can work on it to make sure everything is good before it goes into a release. |
OS X work can be found here |
Great! |
Glad I could help out & good to see this is being adopted by the project! I have been testing the charts in an OSX app and have not seen any major issues. Line, bar, radar, pie and scatter plots seem to work fine. Some things to work on:
|
No Dynamic Type in OSX... |
I'm not too much worried about defaults - those could be adjusted later... Let's get the real problems fixed first :-) |
It turns out that there's a |
There are issues with "nsuiGestureRecognizerShouldBegin" though - as it is not really mapped to anything. |
This commit adds a thin UIKit/Cocoa abstraction layer (Util/ChartsPlatform.swift). It also adds an OS X demo application.
With reference to #43