Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set code signing identity for iOS targets #811

Merged
merged 2 commits into from
Mar 8, 2016
Merged

Set code signing identity for iOS targets #811

merged 2 commits into from
Mar 8, 2016

Conversation

krbarnes
Copy link
Contributor

@krbarnes krbarnes commented Mar 7, 2016

After including ios-charts in my project as a submodule, my build was broken because the project file= specified that the framework should not be signed. This patch changes the code signing identity on the iOS targets to the generic "iPhone Developer" for debug builds and "iPhone Distribution" for release.

Interestingly the tvOS targets already specify 'iPhone Developer' as the code signing identity. Release builds on that platform likely should be built using 'iPhone Distribution' as well.

danielgindi added a commit that referenced this pull request Mar 8, 2016
Set code signing identity for iOS targets
@danielgindi danielgindi merged commit a82a7e5 into ChartsOrg:master Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants