Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new pie chart renderer with polyline indicate #869

Merged
merged 3 commits into from
Apr 1, 2016
Merged

Add new pie chart renderer with polyline indicate #869

merged 3 commits into from
Apr 1, 2016

Conversation

wjacker
Copy link
Contributor

@wjacker wjacker commented Mar 22, 2016

Hey guys,

I add new pie chart renderer with polyline indicate, the appearance look like:

image
please have a look and see if this can merge into master branch :-)

@danielgindi
Copy link
Collaborator

@wjacker thank you very much! This is a wonderful contribution.
I will merge it to another branch and introduce this as a feature for the current renderer to avoid duplicate code. (If you want, you can try and do that yourself)

@wjacker
Copy link
Contributor Author

wjacker commented Mar 22, 2016

@danielgindi awesome, please help me do that merge, many thanks!😄

@Perjan
Copy link

Perjan commented Mar 23, 2016

Awesome, hey @danielgindi please merge it man :)

@danielgindi
Copy link
Collaborator

Yes do not worry guys :-)
It's not everyday that I have time to work on PRs... But I'm on it.
There's some work to merge it as a feature for the basic renderer, and more work to port it to Android as we're cross platform.

But as I said, I'm on it ;-)

@danielgindi
Copy link
Collaborator

This is merged to branch labels-around-pie, and will be merged as soon as I'll completed the Android side of it

@danielgindi danielgindi merged commit d078986 into ChartsOrg:master Apr 1, 2016
@danielgindi
Copy link
Collaborator

Yeah we're done!
Now you can choose for either x or y labels - to render in slice of around the pie with lines.
The demo shows that you can separate them.

Thank you for your contribution!

@BurhanMughal
Copy link

@wjacker Thank you very much for awesome work, Unfortunately I can't implement right now, Will be in my consideration in future.
Thanks Man!

@liuxuan30
Copy link
Member

great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants