Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 1.1 #9

Closed
wants to merge 10 commits into from
Closed

Swift 1.1 #9

wants to merge 10 commits into from

Conversation

pmairoldi
Copy link
Collaborator

Since Xcode 6.3 and Swift 1.2 are still in beta this lovely library cannot be used when submitting to the store. This is a stopgap before Xcode 6.3 is final and could be added as a legacy branch.

Changes:

  • Changed @objc public enum to NS_Enum
  • Changed 1.2 specific syntax such as as!
  • Removed __nonnull annotations
  • Updated readme

@danielgindi
Copy link
Collaborator

.Well this is nice for those who are eager to send it to the AppStore already,
But will mess up the code for backwards support for an incomplete language...

I will keep this PR live so other people know about your fork, but in the meantime I will continue developing so bear in mind you'll have to update to Xcode 6.3 in April 24. That's the release date for Xcode 6.3 :)

Btw, I would love to know about apps using this library!

@pmairoldi
Copy link
Collaborator Author

Sounds good.

The reason I did this is that I plan on working on a project that will use this but Xcode 6.3 might not be out by the time I need a release. I doubt 6.3 will be available on the 24th, wouldn't make much sense. Xcode 6.2 and iOS 8.2 were for the watch and are already live. I hope I'm wrong but without knowing for sure better safe than sorry.

@danielgindi
Copy link
Collaborator

danielgindi commented Apr 1, 2015 via email

@vishw3
Copy link

vishw3 commented Apr 2, 2015

@danielgindi Are u sure 6.3 will be released on april 24th.

@danielgindi
Copy link
Collaborator

Well, known facts are on my side:

So I don't know if it's April 24th, but I'm pretty sure it's April-something.

@bach942
Copy link

bach942 commented Apr 3, 2015

Be able to use Swift 1.1 was also a concern when I was looking for charting tools for iOS. This seems to have many features that I'm looking for and as a bonus there is an Android version.

@pmairoldi
Copy link
Collaborator Author

Since 6.3 is out. There is no need for this anymore. I will keep the branch in case anyone needs it but they really shouldn't anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants