Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update constant for baidu add ENIRE Speed ENIRE Lite model #5040

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

consistent-k
Copy link
Contributor

@consistent-k consistent-k commented Jul 17, 2024

💻 变更类型 | Change Type

  • feat
  • fix
  • refactor
  • perf
  • style
  • test
  • docs
  • ci
  • chore
  • build

🔀 变更说明 | Description of Change

update constant for baidu add ENIRE Speed和ENIRE Lite model
更新百度的模型配置 & 新增 ENIRE Speed和ENIRE Lite模型

📝 补充信息 | Additional Information

This model is a model that can be called for free on Baidu Qianfan platform. We hope to have such configuration.
此模型是百度千帆平台上可以免费调用的模型,期望可以有此项配置。

Summary by CodeRabbit

  • New Features
    • Added support for "ernie-speed," "ernie-speed-128k," and "ernie-speed-8k" models.
  • Improvements
    • Updated endpoint handling for new model conditions to ensure proper routing for the added models.

Copy link

vercel bot commented Jul 17, 2024

@consistent-k is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

coderabbitai bot commented Jul 17, 2024

Walkthrough

The app/constant.ts file has been updated to include new model names "ernie-speed-128k" and "ernie-speed-8k" for the Baidu constant. These additions set specific endpoints for each model, enhancing functionality. The baiduModels array also now includes these new models.

Changes

File Change Summary
app/constant.ts Updated the Baidu constant to handle modelName values "ernie-speed-128k" and "ernie-speed-8k," setting their respective endpoints. Added these models to baiduModels array.

Poem

Amidst the constants, changes brew,
Ernie speeds in, both swift and true.
Models added, endpoints set,
Baidu's speed, the fastest yet.
With code updated, bright and new,
A rabbit hops, a coder's due.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ec95292 and 5a0d0c0.

Files selected for processing (1)
  • app/constant.ts (2 hunks)
Additional comments not posted (2)
app/constant.ts (2)

137-139: Approved changes to the Baidu constant.

The update to handle the "ernie-speed" model by setting a specific endpoint appears correct.

Verify no unintended side effects.
Ensure that this change does not affect the behavior of other models.

Verification successful

Verified: No unintended side effects found.

The changes to handle the "ernie-speed" model by setting a specific endpoint do not affect the behavior of other models. Each model name is mapped to its respective endpoint correctly.

  • "ernie-4.0-8k" -> "completions_pro"
  • "ernie-4.0-8k-preview-0518" -> "completions_adv_pro"
  • "ernie-3.5-8k" -> "completions"
  • "ernie-speed" -> "ernie_speed"
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that other models are not affected by the new endpoint setting.

# Test: Search for other model names in the `Baidu` constant definition.
rg --type typescript -A 5 $'modelName ===' app/constant.ts

Length of output: 94


Script:

#!/bin/bash
# Description: Verify that other models are not affected by the new endpoint setting.

# Test: Search for other model names in the `Baidu` constant definition.
rg --type ts -A 5 $'modelName ===' app/constant.ts

Length of output: 462


231-231: Approved addition of "ernie-speed" to the baiduModels array.

The inclusion of the new model in the array is straightforward and aligns with the PR objectives.

Verify integration and usage.
Check how the baiduModels array is used throughout the codebase to ensure the new model integrates smoothly.

Verification successful

Approved addition of "ernie-speed" to the baiduModels array.

The new model integrates smoothly with the existing structure and usage of the baiduModels array.

  • app/constant.ts: The baiduModels array is correctly defined and used to map model names to objects.
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of the `baiduModels` array in the codebase.

# Test: Search for usages of the `baiduModels` array.
rg --type typescript $'baiduModels' app/

Length of output: 74


Script:

#!/bin/bash
# Description: Verify the usage of the `baiduModels` array in the codebase.

# Test: Search for usages of the `baiduModels` array.
rg --type ts 'baiduModels' app/

Length of output: 119


Script:

#!/bin/bash
# Description: Extract lines around the usage of `baiduModels` in `app/constant.ts` to understand its context.

# Extract lines around the definition and usage of `baiduModels`.
rg --type ts 'baiduModels' -A 5 -B 5 app/constant.ts

Length of output: 526

Copy link
Contributor

Your build has completed!

Preview deployment

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5a0d0c0 and 5dc731b.

Files selected for processing (1)
  • app/constant.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • app/constant.ts

@consistent-k consistent-k changed the title update constant for baidu add ernie-speed model update constant for baidu add ENIRE Speed ENIRE Lite model Jul 17, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5dc731b and 9aabc4a.

Files selected for processing (1)
  • app/constant.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • app/constant.ts

@Dogtiti Dogtiti merged commit 2e9f701 into ChatGPTNextWeb:main Jul 17, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants