support tauri-v2 #5518
support tauri-v2 #5518
Conversation
|
@WtecHtec is attempting to deploy a commit to the NextChat Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe pull request includes updates across several files, primarily focusing on versioning, dependency management, and configuration for a Tauri application. Key changes involve modifying how the version string is constructed, adding new scripts for iOS support, upgrading dependencies, and introducing a new JSON file for application capabilities. Additionally, it restructures the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Your build has completed! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
Outside diff range and nitpick comments (2)
src-tauri/tauri.conf.json (1)
3-5: LGTM! Consider updating the identifier.The product information looks good. The name "NextChat" is appropriate, and the version follows semantic versioning.
Consider updating the identifier from "NextChat.template.dev" to a more production-ready value, such as "com.yourcompany.NextChat", especially if this configuration is intended for release builds.
src-tauri/Cargo.toml (1)
47-48: Minor: Remove extra empty lineThere's an extra empty line at the end of the file. While this doesn't affect functionality, it's generally good practice to end files with a single newline character for consistency.
Consider removing the extra empty line at the end of the file.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (3)
package-lock.jsonis excluded by!**/package-lock.jsonsrc-tauri/Cargo.lockis excluded by!**/*.lockyarn.lockis excluded by!**/yarn.lock,!**/*.lock
Files selected for processing (8)
- app/config/build.ts (1 hunks)
- package.json (4 hunks)
- src-tauri/.gitignore (1 hunks)
- src-tauri/Cargo.toml (1 hunks)
- src-tauri/capabilities/main.json (1 hunks)
- src-tauri/src/lib.rs (1 hunks)
- src-tauri/src/main.rs (1 hunks)
- src-tauri/tauri.conf.json (1 hunks)
Additional comments not posted (20)
src-tauri/.gitignore (1)
4-4: LGTM: Addition of/gen/to .gitignore is appropriate.The addition of
/gen/to the .gitignore file is a good practice. This likely excludes generated files specific to Tauri v2 from version control, which is consistent with the existing pattern of ignoring compiled files and executables in the/target/directory.src-tauri/capabilities/main.json (4)
2-3: LGTM: Identifier and description are clear and appropriate.The identifier "main" and the description "permissions for desktop app" accurately represent the purpose of this capability set for the desktop application.
1-16: Overall, the capabilities file is well-structured and appropriate for a desktop application.The
main.jsonfile provides a clear and concise definition of capabilities for the desktop application. It includes necessary permissions for dialogs, updates, and core events, which are typical requirements for desktop apps.To ensure the configuration is optimal:
- Verify that "main" is the only window requiring these capabilities.
- Confirm that all listed permissions are actually used in the application.
These verifications will help maintain the principle of least privilege, ensuring the app has all necessary permissions without granting unnecessary access.
6-15: Verify that all listed permissions are necessary for the application.The permissions listed cover dialog interactions, app updates, and core event listening, which are common requirements for desktop applications. However, it's crucial to ensure that each permission is necessary for the app's functionality.
To verify the usage of these permissions in the application, run the following script:
#!/bin/bash # Description: Search for usage of dialog, updater, and core event APIs in the codebase # Test: Look for dialog API usage echo "Searching for dialog API usage:" rg --type rust -e 'dialog::' -e 'ask' -e 'message' # Test: Look for updater API usage echo "Searching for updater API usage:" rg --type rust -e 'updater::' -e 'check' -e 'download_and_install' # Test: Look for core event API usage echo "Searching for core event API usage:" rg --type rust -e 'event::' -e 'listen'Please review the script output to confirm that each permission is utilized in the codebase.
4-5: Verify if "main" is the only window requiring these capabilities.The "local" setting and "windows" array look good. However, it's worth confirming that "main" is indeed the only window that requires these capabilities. If there are other windows in the application, consider whether they need the same permissions.
To verify the window names used in the application, run the following script:
Verification successful
Verified that "main" is the only window requiring these capabilities.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Search for window creation or references in the codebase # Test: Look for window creation or references rg --type rust -e 'create_window' -e 'window\..*\(' -e '"window": ".*"'Length of output: 651
src-tauri/src/main.rs (2)
1-16: Clarify how these changes support Tauri v2 and affect application features.The changes in this file represent a significant shift in how the application is initialized. However, it's not immediately clear how these changes relate to supporting Tauri v2 as mentioned in the PR objectives. Please provide clarification on:
- How does this new implementation support Tauri v2?
- Is the window state management plugin (
tauri_plugin_window_state) still being used? If so, where is it configured?- Are there any changes to the application's feature set or behavior as a result of this new implementation?
- How are Tauri-specific configurations (like the ones previously in the builder pattern) now being managed?
Additionally, consider adding comments to explain the rationale behind these changes and how they relate to Tauri v2 support. This will help future maintainers understand the context of this implementation.
Let's search for any Tauri v2 related configurations or dependencies:
#!/bin/bash # Search for Tauri v2 related configurations or dependencies rg --type toml -g 'Cargo.toml' 'tauri.*=.*2' -A 5
14-16: Provide more context for the newnextchat::run()implementation.The new implementation is significantly simpler, but it's unclear what
nextchat::run()does or where it's defined. This change might affect how the application is initialized and configured.Could you please provide more information about:
- The
nextchatmodule: Where is it defined? What does it contain?- The
run()function: What does it do? How does it compare to the previous Tauri builder implementation?- Error handling: The previous implementation had explicit error handling. How are errors managed in the new implementation?
To help understand the context, let's search for the
nextchatmodule:src-tauri/tauri.conf.json (1)
1-40: Overall configuration review summary.The Tauri configuration file has been significantly updated and streamlined. While most changes are appropriate, there are a few areas that require attention:
- Ensure consistency between the product name and window title.
- Implement a proper Content Security Policy.
- Review the macOS signing identity for distribution purposes.
- Optimize target platforms to include only necessary ones.
- Verify the frontend distribution path.
Please address these points to improve the configuration's robustness and security.
app/config/build.ts (1)
13-13: Verify the structure of tauriConfig and update documentation if needed.The change from
tauriConfig.package.versiontotauriConfig.versionsuggests a structural change in thetauri.conf.jsonfile. This modification appears to simplify the version retrieval, which is good for maintainability.However, to ensure this change doesn't introduce any issues:
- Confirm that
tauriConfig.versionexists and contains the correct version string.- Update any documentation or comments that might reference the old
package.versionstructure.- Ensure this change is consistent across the entire project where version information is used.
Let's verify the structure of the tauriConfig object:
These commands will help confirm the new structure and identify any places where the old structure might still be in use.
Verification successful
tauriConfig structure verified successfully.
tauriConfig.versionis correctly set to"0.1.0".- The
package.versionproperty no longer exists.- No remaining references to
tauriConfig.package.versionfound in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the structure of tauriConfig in tauri.conf.json # Test: Check if 'version' exists directly under the root of tauri.conf.json jq '.version' src-tauri/tauri.conf.json # Test: Check if 'package.version' still exists (it shouldn't if the structure has changed) jq '.package.version' src-tauri/tauri.conf.json # Test: Search for any remaining uses of 'package.version' in the codebase rg --type typescript --type javascript 'tauriConfig\.package\.version'Length of output: 208
Script:
#!/bin/bash # Description: Re-verify the structure of tauriConfig in tauri.conf.json and search for any residual 'package.version' usage # Check if 'version' exists directly under the root of tauri.conf.json jq '.version' src-tauri/tauri.conf.json # Confirm 'package.version' does not exist jq 'has("package") and .package | has("version")' src-tauri/tauri.conf.json # Search for any remaining uses of 'package.version' in the codebase without specifying file types rg 'tauriConfig\.package\.version'Length of output: 253
Script:
#!/bin/bash # Description: Correctly verify the structure of tauriConfig in tauri.conf.json and search for any residual 'package.version' usage # Check if 'version' exists directly under the root of tauri.conf.json jq '.version' src-tauri/tauri.conf.json # Confirm 'package.version' does not exist, handling cases where 'package' might not exist jq 'has("package") and (.package | has("version"))' src-tauri/tauri.conf.json # Search for any remaining uses of 'package.version' in the codebase without specifying file types rg 'tauriConfig\.package\.version'Length of output: 170
src-tauri/Cargo.toml (4)
12-14: LGTM: New library configuration addedThe addition of the
[lib]section with multiple crate types is a good change. It allows the project to be used flexibly:
- As a static library (
staticlib)- As a dynamic library for FFI (
cdylib)- As a Rust library (
rlib)This change enhances the project's versatility, allowing it to be integrated into various types of projects.
35-40: Approved: Release profile optimizations addedThe addition of the
[profile.release]section with various optimizations is a good practice for reducing binary size and potentially improving performance. Here's a breakdown of the changes:
panic = "abort": This removes expensive panic clean-up logic, reducing binary size but also limiting error recovery capabilities.codegen-units = 1: This allows for better optimization but may increase compile times.lto = true: Link Time Optimization can significantly reduce binary size and improve performance.opt-level = "s": This optimizes for binary size rather than speed.strip = true: Removing debug symbols further reduces binary size but makes debugging release builds more difficult.These are generally good choices for a release build focused on minimal binary size. However, it's important to document these choices and their implications, especially regarding error handling and debugging capabilities in production.
Consider adding comments in the
Cargo.tomlfile or updating the project documentation to explain these optimization choices and their trade-offs.
19-19: Approved: Tauri-build dependency updated to v2 RCThe update of
tauri-buildto version "2.0.0-rc" aligns with the PR objective of supporting Tauri v2. This is a significant version jump from the previous 1.x version.However, please note that this is a release candidate version. While it's generally fine for development, ensure thorough testing before deploying to production. Also, keep an eye out for the stable 2.0.0 release and plan to update when it becomes available.
To ensure consistency across the project, let's check if other Tauri-related dependencies are also updated to v2:
#!/bin/bash # Check for Tauri-related dependencies versions grep -E "tauri.*version" src-tauri/Cargo.toml
22-32: Approved with suggestions: Dependencies updated for Tauri v2The updates to the dependencies section are comprehensive and align with the move to Tauri v2. Here are some observations and suggestions:
The
tauridependency is updated to "2.0.0-rc", which is good. However, all previously specified features have been removed. Please clarify if this is intentional and ensure it doesn't unintentionally remove required functionality.New Tauri plugins have been added (shell, devtools, updater, dialog), which likely expand the application's capabilities. It would be beneficial to document these new features in the project documentation.
The addition of
spectaand related dependencies with specific versions (e.g., "=2.0.0-rc.20") indicates a need for precise version control. This is good for consistency but may require more frequent updates.The
logdependency has been added, which is great for improving the project's logging capabilities.Consider adding comments in the
Cargo.tomlfile or updating the project documentation to explain the purpose of each new dependency, especially the Tauri plugins.Let's verify if the removal of tauri features is intentional:
Verification successful
Verified: Removal of
taurifeatures is intentionalThe
featuresfor thetauridependency were already set to an empty array in the previous commit, confirming that their removal was intentional and does not affect the project's functionality. No additional actions are required regarding this change.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for previous tauri features git show HEAD^:src-tauri/Cargo.toml | grep -A5 'tauri.*version'Length of output: 537
src-tauri/src/lib.rs (4)
13-15: DemoEvent struct definition looks goodThe
DemoEventstruct is well-defined with appropriate derive macros for serialization, deserialization, and Tauri event handling.
17-28: Run function initialization and logging setup look goodThe conditional compilation for mobile and debug builds, along with the logging setup, is well-implemented. This ensures appropriate behavior across different build configurations.
30-46: Specta builder setup and TypeScript bindings export look goodThe Specta builder is correctly configured with the
greetcommand andDemoEvent. The conditional export of TypeScript bindings for non-mobile debug builds is a good practice, enhancing development experience without affecting production builds.
50-50: Consider the updater plugin configurationThe updater plugin is currently commented out. If auto-updates are intended for this application, consider uncommenting and properly configuring this plugin. If it's intentionally disabled, it might be clearer to remove the line entirely or add a comment explaining why it's disabled.
Verification successful
Updater Plugin Configuration Verified
The updater plugin is not used elsewhere in the project. If auto-updates are intended, uncomment and properly configure the plugin. If not needed, consider removing the commented-out line for clarity.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if the updater plugin is used elsewhere in the project rg --type rust "tauri_plugin_updater"Length of output: 123
package.json (3)
16-17: LGTM: New iOS scripts added for Tauri v2 supportThe addition of
ios:initandios:devscripts is a good enhancement for iOS development support with Tauri v2. These scripts will streamline the initialization and development process for iOS.
37-37: Acknowledge mermaid dependency relocationThe
mermaiddependency has been moved within the dependencies list. This is a minor change that doesn't affect functionality, as the version remains unchanged at^10.6.1.
58-58: Approve @tauri-apps/cli update with a note of cautionThe update of
@tauri-apps/clito version^2.0.0-rc.0aligns with the goal of supporting Tauri v2. However, be cautious about using a release candidate version in production, as it may introduce instability. Consider pinning to a specific rc version (e.g., "2.0.0-rc.0" without the caret) to avoid automatic updates to newer rc versions, which could introduce breaking changes.To ensure compatibility, let's check for any Tauri-related warnings or errors:
src-tauri/src/main.rs
Outdated
| // #![cfg_attr(not(debug_assertions), windows_subsystem = "windows")] | ||
|
|
||
| // fn main() { | ||
| // tauri::Builder::default() | ||
| // .plugin(tauri_plugin_window_state::Builder::default().build()) | ||
| // .run(tauri::generate_context!()) | ||
| // .expect("error while running tauri application"); | ||
| // } |
There was a problem hiding this comment.
Remove commented-out code and consider Windows subsystem configuration.
-
The
cfg_attrdirective for Windows subsystem configuration is commented out. This might cause a console window to appear in release mode on Windows. Consider uncommenting this line if you want to suppress the console window. -
The commented-out Tauri builder code should be removed. Keeping unused code in the main file can lead to confusion and maintenance issues. If this code is kept for reference, consider moving it to documentation or a separate file.
Suggested changes:
-// #![cfg_attr(not(debug_assertions), windows_subsystem = "windows")]
+#![cfg_attr(not(debug_assertions), windows_subsystem = "windows")]
-// fn main() {
-// tauri::Builder::default()
-// .plugin(tauri_plugin_window_state::Builder::default().build())
-// .run(tauri::generate_context!())
-// .expect("error while running tauri application");
-// }Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // #![cfg_attr(not(debug_assertions), windows_subsystem = "windows")] | |
| // fn main() { | |
| // tauri::Builder::default() | |
| // .plugin(tauri_plugin_window_state::Builder::default().build()) | |
| // .run(tauri::generate_context!()) | |
| // .expect("error while running tauri application"); | |
| // } | |
| #![cfg_attr(not(debug_assertions), windows_subsystem = "windows")] |
src-tauri/tauri.conf.json
Outdated
| "plugins": {}, | ||
| "app": { | ||
| "windows": [ | ||
| { | ||
| "fullscreen": false, | ||
| "height": 600, | ||
| "resizable": true, | ||
| "title": "NextChat", | ||
| "width": 960, | ||
| "hiddenTitle": true, | ||
| "titleBarStyle": "Overlay" | ||
| "title": "quantum", | ||
| "width": 800, | ||
| "height": 600 | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "security": { | ||
| "csp": null | ||
| }, | ||
| "withGlobalTauri": false | ||
| }, |
There was a problem hiding this comment.
Review window title and Content Security Policy settings.
The app configuration looks generally good, but there are two points to consider:
-
The window title "quantum" doesn't match the product name "NextChat". Consider aligning these for consistency.
-
The Content Security Policy (CSP) is set to null, which might have security implications.
Please review and update the following:
- Update the window title to match the product name:
- "title": "quantum",
+ "title": "NextChat",- Implement a proper Content Security Policy instead of setting it to null. A basic example might be:
- "csp": null
+ "csp": "default-src 'self'; script-src 'self'"Adjust the CSP as needed based on your application's requirements and security needs.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "plugins": {}, | |
| "app": { | |
| "windows": [ | |
| { | |
| "fullscreen": false, | |
| "height": 600, | |
| "resizable": true, | |
| "title": "NextChat", | |
| "width": 960, | |
| "hiddenTitle": true, | |
| "titleBarStyle": "Overlay" | |
| "title": "quantum", | |
| "width": 800, | |
| "height": 600 | |
| } | |
| ] | |
| } | |
| ], | |
| "security": { | |
| "csp": null | |
| }, | |
| "withGlobalTauri": false | |
| }, | |
| "plugins": {}, | |
| "app": { | |
| "windows": [ | |
| { | |
| "title": "NextChat", | |
| "width": 800, | |
| "height": 600 | |
| } | |
| ], | |
| "security": { | |
| "csp": "default-src 'self'; script-src 'self'" | |
| }, | |
| "withGlobalTauri": false | |
| }, |
There was a problem hiding this comment.
quantum 这个是其他项目的名称,,window 配置尽量保持和原来一致
There was a problem hiding this comment.
@Leizhenpeng，明白了，谢谢您的澄清。我会在未来的评审中注意保持窗口配置与原始项目一致。
（・∧・）？
Learnings added
Learnt from: Leizhenpeng
PR: ChatGPTNextWeb/ChatGPT-Next-Web#5518
File: src-tauri/tauri.conf.json:12-25
Timestamp: 2024-09-24T11:44:10.517Z
Learning: Quantum 是其他项目的名称，窗口配置应保持与原始项目一致。
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
src-tauri/tauri.conf.json
Outdated
| "bundle": { | ||
| "macOS": { | ||
| "signingIdentity": "-" | ||
| }, | ||
| "active": true, | ||
| "targets": "all", | ||
| "icon": [ | ||
| "icons/32x32.png", | ||
| "icons/128x128.png", | ||
| "icons/128x128@2x.png", | ||
| "icons/icon.icns", | ||
| "icons/icon.ico" | ||
| ] | ||
| } |
There was a problem hiding this comment.
Review macOS signing identity and target platforms.
The bundle configuration looks generally good, but there are two points to consider:
-
The macOS signing identity is set to "-", which might cause issues when distributing the app.
-
The targets are set to "all", which might include unnecessary platforms and increase build times.
Please review and consider updating the following:
-
Set a proper macOS signing identity for distribution. If you're not distributing on macOS, you can remove this section.
-
Specify only the necessary target platforms instead of "all". For example:
- "targets": "all",
+ "targets": ["app", "deb", "msi", "dmg", "updater"]Adjust the targets based on your actual distribution needs.
Committable suggestion was skipped due to low confidence.
src-tauri/src/lib.rs
Outdated
| fn greet(app: tauri::AppHandle, name: &str) -> String { | ||
| DemoEvent("Demo event fired from Rust 🦀".to_string()) | ||
| .emit(&app) | ||
| .ok(); | ||
| format!("Hello, {}! You've been greeted from Rust!", name) | ||
| } |
There was a problem hiding this comment.
Improve error handling in the greet function
The greet function emits a DemoEvent but ignores any potential errors. Consider handling or at least logging the error for better debugging and reliability.
Here's a suggested improvement:
fn greet(app: tauri::AppHandle, name: &str) -> String {
- DemoEvent("Demo event fired from Rust 🦀".to_string())
- .emit(&app)
- .ok();
+ if let Err(e) = DemoEvent("Demo event fired from Rust 🦀".to_string()).emit(&app) {
+ log::error!("Failed to emit DemoEvent: {:?}", e);
+ }
format!("Hello, {}! You've been greeted from Rust!", name)
}Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| fn greet(app: tauri::AppHandle, name: &str) -> String { | |
| DemoEvent("Demo event fired from Rust 🦀".to_string()) | |
| .emit(&app) | |
| .ok(); | |
| format!("Hello, {}! You've been greeted from Rust!", name) | |
| } | |
| fn greet(app: tauri::AppHandle, name: &str) -> String { | |
| if let Err(e) = DemoEvent("Demo event fired from Rust 🦀".to_string()).emit(&app) { | |
| log::error!("Failed to emit DemoEvent: {:?}", e); | |
| } | |
| format!("Hello, {}! You've been greeted from Rust!", name) | |
| } |
src-tauri/tauri.conf.json
Outdated
| "security": { | ||
| "csp": null | ||
| }, | ||
| "withGlobalTauri": false |
There was a problem hiding this comment.
否则，代码逻辑中有挺多地方直接从window对象上读取tauri对象的时候会失败
src-tauri/tauri.conf.json
Outdated
| "width": 960, | ||
| "hiddenTitle": true, | ||
| "titleBarStyle": "Overlay" | ||
| "title": "quantum", |
There was a problem hiding this comment.
这里title应该和旧版保持一致
宽度高度，以及是否支持全屏等属性，也要保持一致
yarn.lock
Outdated
| @@ -4,40 +4,40 @@ | |||
|
|
|||
| "@aashutoshrathi/word-wrap@^1.2.3": | |||
| version "1.2.6" | |||
| resolved "https://registry.yarnpkg.com/@aashutoshrathi/word-wrap/-/word-wrap-1.2.6.tgz#bd9154aec9983f77b3a034ecaa015c2e4201f6cf" | |||
| resolved "https://registry.npmjs.org/@aashutoshrathi/word-wrap/-/word-wrap-1.2.6.tgz" | |||
There was a problem hiding this comment.
尽量不要更改yarn.lock中的 这个域名。
这样，对原来的开发者来说会造成困惑，例如之前的开发者环境里面的yarn有一套缓存的东西，都可能失效，需要全部重新安装...
There was a problem hiding this comment.
按道理讲，这个文件应该只出现版本更新或者新的依赖包，而不出现域名和hash的更改
也就是说，这个文件不应该出现2000+行的更改，这会给代码review增加困难
There was a problem hiding this comment.
现在新的代码，看起来应该都是依赖库自己更新的了，应该没问题了
src-tauri/Cargo.toml
Outdated
| "window-unminimize", | ||
| ] } | ||
| tauri-plugin-window-state = { git = "https://github.com/tauri-apps/plugins-workspace", branch = "v1" } | ||
| tauri = { version = "2.0.0-rc", features = [] } |
| "csp": null, | ||
| "dangerousUseHttpScheme": true | ||
| }, | ||
| "updater": { |
|
这个分支先合并到 feat-tauir-v2分支，后续会在这个分支处理打包以及迁移http-api的逻辑。 |
This branch is first merged into the feat-tauir-v2 branch, and the logic of packaging and migrating http-api will be processed in this branch later. |
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
Modify tauri to v2 version
📝 补充信息 | Additional Information
Summary by CodeRabbit
Release Notes
New Features
Improvements
Bug Fixes
Chores
.gitignoreto exclude generated files.