feat: Solve the problem of using openai interface protocol for user-d…

[Dean-YZG]

…efined claude model & add some famous webdav endpoints

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextchat	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 9, 2024 0:51am

[github-actions]

Your build has completed!

Preview deployment

[H0llyW00dzZ]

Just letting you know

[H0llyW00dzZ]

by the way you can simplicity it by using this method

remove this

  var api: ClientApi;
  if (config.modelConfig.model.startsWith("gemini")) {
    api = new ClientApi(ModelProvider.GeminiPro);
  } else if (identifyDefaultClaudeModel(config.modelConfig.model)) {
    api = new ClientApi(ModelProvider.Claude);
  } else {
    api = new ClientApi(ModelProvider.GPT);
  }

then replace with this

const modelProviderMap: Record<string, ModelProvider> = {
  gemini: ModelProvider.GeminiPro,
  claude: ModelProvider.Claude,
};

const defaultModelProvider = ModelProvider.GPT;
const modelPrefix = config.modelConfig.model.split("-")[0];

const api = new ClientApi(
  modelProviderMap[modelPrefix] || identifyDefaultClaudeModel(config.modelConfig.model)
    ? ModelProvider.Claude
    : defaultModelProvider
);

[Dean-YZG]

Some users invoke the claude model using openai's interface protocol, possibly with a proxy service in between, so the problem I'm actually trying to solve with this code is: Only the default claude model provided by our system (marked anthropic on the corresponding provider) can use the anthropic interface protocol

[Dean-YZG]

However, semantically, this code of yours does not solve the problem,but, you mentioned a very important point, that is the importance of "provider", next, the entity relationships will be sorted out, refactoring the logic, making it easier for the application to extend the new model

[H0llyW00dzZ]

However, semantically, this code of yours does not solve the problem,but, you mentioned a very important point, that is the importance of "provider", next, the entity relationships will be sorted out, refactoring the logic, making it easier for the application to extend the new model

it's looks bad so many if else if else statement, can't imagine if there is lot's of service provider

  var api: ClientApi;
  if (config.modelConfig.model.startsWith("gemini")) {
    api = new ClientApi(ModelProvider.GeminiPro);
  } else if (identifyDefaultClaudeModel(config.modelConfig.model)) {
    api = new ClientApi(ModelProvider.Claude);
  } else {
    api = new ClientApi(ModelProvider.GPT);
  }

[H0llyW00dzZ]

and this one as well

import { useAccessStore } from "../store/access";
import { useAppConfig } from "../store/config";
import { collectModels } from "./model";

export function identifyDefaultClaudeModel(modelName: string) {
  const accessStore = useAccessStore.getState();
  const configStore = useAppConfig.getState();

  const allModals = collectModels(
    configStore.models,
    [configStore.customModels, accessStore.customModels].join(","),
  );

  const modelMeta = allModals.find((m) => m.name === modelName);

  return (
    modelName.startsWith("claude") &&
    modelMeta &&
    modelMeta.provider?.providerType === "anthropic"
  );
}

[Innocent-children]

However, semantically, this code of yours does not solve the problem,but, you mentioned a very important point, that is the importance of "provider", next, the entity relationships will be sorted out, refactoring the logic, making it easier for the application to extend the new model

I think you can judge which protocol to use based on the secret key of the AI model, because the secret key formats of different models are different.