Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usernames without nicknames in logs are duplicated #4697

Closed
4 tasks done
sando opened this issue Jun 20, 2023 · 0 comments · Fixed by #4742
Closed
4 tasks done

Usernames without nicknames in logs are duplicated #4697

sando opened this issue Jun 20, 2023 · 0 comments · Fixed by #4742
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user Feature: Logs Issues related to Chatterino Logs

Comments

@sando
Copy link
Contributor

sando commented Jun 20, 2023

Checklist

  • I'm reporting a problem with Chatterino
  • I've verified that I'm running the most recent nightly build or stable release
  • I've looked for my problem on the wiki
  • I've searched the issues and pull requests for similar looking reports

Describe your issue

If a user doesn't have a nickname set, their username is duplicated in chat logging. See example:

# Current behaviour:
[16:07:31] praxis099  praxis099: bag for cup but no cup
[16:07:44] beyson2301(龍亨街市) 龍亨街市 beyson2301: BBQ in 31 degree celsius monkaS

# With nickname set ("streamelements" set to "se"):
[18:47:29] se  streamelements: Posture check SwiftRage

# Previous behaviour: 
[15:40:19]  koromochii: KEKW
[15:40:20] ダスビーター das_beater: POGSPIN

Appears to be an unintentional side-effect due to the way #4663 was implemented (logging uses the search text of the message). IMO, nicknames don't really belong in chatlogs, but if we decide to include them, they probably shouldn't double-up like that.

Screenshots

No response

OS and Chatterino Version

Chatterino Nightly 2.4.4 (commit 53b044c) built on 2023-06-18 with Qt 6.5.0, MSVC 193632532 Running on Windows 11 Version 23H2, kernel: 10.0.25381

@sando sando added the issue-report An issue reported by a user. label Jun 20, 2023
@pajlada pajlada added bug Something isn't working as intended, or works in a confusing/unintuitive way for the user Feature: Logs Issues related to Chatterino Logs and removed issue-report An issue reported by a user. labels Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user Feature: Logs Issues related to Chatterino Logs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants