Consider nicknames when searching for messages #4663
Conversation
|
chatterino2/src/widgets/settingspages/NicknamesPage.cpp Lines 20 to 23 in e9432d3 This will need to be updated also |
|
Ah yeah, I updated it now to remove the search part from the text |
pajlada
changed the title
|
@chrrs As a first-time contributor, you can add yourself to the contributors list that's shown inside the About page in Chatterino. If you want this, wait for this PR to be merged in, then open a new PR where you modify the |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -64,7 +64,11 @@ MessagePtr IrcMessageBuilder::build() | |||
| // message | |||
| this->addIrcMessageText(this->originalMessage_); | |||
|
|
|||
| this->message().searchText = this->message().localizedName + " " + | |||
| QString stylizedUsername = | |||
There was a problem hiding this comment.
warning: variable 'stylizedUsername' of type 'QString' can be declared 'const' [misc-const-correctness]
| QString stylizedUsername = | |
| QString const stylizedUsername = |
| @@ -64,7 +64,11 @@ | |||
| // message | |||
| this->addIrcMessageText(this->originalMessage_); | |||
|
|
|||
| this->message().searchText = this->message().localizedName + " " + | |||
| QString stylizedUsername = | |||
| this->stylizeUsername(this->userName, this->message()); | |||
There was a problem hiding this comment.
warning: static member accessed through instance [readability-static-accessed-through-instance]
| this->stylizeUsername(this->userName, this->message()); | |
| chatterino::IrcMessageBuilder::stylizeUsername(this->userName, this->message()); |
| @@ -294,8 +294,12 @@ MessagePtr TwitchMessageBuilder::build() | |||
|
|
|||
| this->addWords(splits, twitchEmotes); | |||
|
|
|||
| QString stylizedUsername = | |||
There was a problem hiding this comment.
warning: variable 'stylizedUsername' of type 'QString' can be declared 'const' [misc-const-correctness]
| QString stylizedUsername = | |
| QString const stylizedUsername = |
| @@ -294,8 +294,12 @@ | |||
|
|
|||
| this->addWords(splits, twitchEmotes); | |||
|
|
|||
| QString stylizedUsername = | |||
| this->stylizeUsername(this->userName, this->message()); | |||
There was a problem hiding this comment.
warning: static member accessed through instance [readability-static-accessed-through-instance]
| this->stylizeUsername(this->userName, this->message()); | |
| chatterino::TwitchMessageBuilder::stylizeUsername(this->userName, this->message()); |
| @@ -81,6 +81,22 @@ bool ConcurrentSettings::isMutedChannel(const QString &channelName) | |||
| return false; | |||
| } | |||
|
|
|||
| boost::optional<QString> ConcurrentSettings::matchNickname( | |||
There was a problem hiding this comment.
warning: method 'matchNickname' can be made static [readability-convert-member-functions-to-static]
src/singletons/Settings.hpp:49:
- boost::optional<QString> matchNickname(const QString &username);
+ static boost::optional<QString> matchNickname(const QString &username);
With this PR, searching now also finds results using nicknames instead of usernames.
The way I've done this is by prepending the stylized username to the search text, as it seems that nickname matching is based on the stylized username, instead of only the login name / display name. This isn't the best solution, as it does lead to a bit of duplication in the search text for users without a nickname (for example, for the username
chrrrs, it would lead to something likechrrrs chrrrs: message). If anyone has a better solution here, I'd be up for changing things around.