-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Don't use QCompleter prefix filter #4855
fix: Don't use QCompleter prefix filter #4855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
issue could have been* resolved on a per-channel basis without a client restart, but seems like this better explains the bug |
@pajlada current problem is as follows: When the client is started with the setting The changes in this PR resolve the first problem. but, this setting also effects commands see #3440 on 06eb30a (before any input completion overhaul): on 4d8b623: | tested #4853 as well, no change on this PR : So this PR fixes the issue with commands, but does not fix the problem with commands not respecting the setting, though only partially caused by this PR Problem likely stems from the way commands are handled in 4d8b623 |
Description
Toggling the "Only search for emote autocompletion at the start of emote names" would require a user to close and reopen a tab for the change to take effect.
The overhaul put the onus of determining completions completely on the Strategy selected. We don't want to limit ourselves to only completing prefixes.