Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more firefox variants for incognito link opening #5503

Merged
merged 5 commits into from
Jul 11, 2024

Conversation

teknsl
Copy link
Contributor

@teknsl teknsl commented Jul 10, 2024

  • firefox-devedition
  • firefox-beta
  • firefox-nightly
  • qutebrowser

* firefox-devedition
* firefox-beta
* firefox-nightly
* qutebrowser
Copy link
Collaborator

@Mm2PL Mm2PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love for us to find browsers either by URL associations or XDG desktop files. XDG desktop files usually have a new-private-window action. We wouldn't need to explicitly add support for every single web browser on the planet. However that might not be worth the complexity.

That said I'm completely ok accepting this patch.

Copy link
Collaborator

@Mm2PL Mm2PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add firefox-developer-edition to the list. And a changelog entry

(I may have misclicked approve before)

src/util/IncognitoBrowser.cpp Show resolved Hide resolved
{"firefox-devedition", "-private-window"},
{"firefox-beta", "-private-window"},
{"firefox-nightly", "-private-window"},
{"qutebrowser", "--target", "private-window"},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This opens a new window, not sure if there is a better version that opens a tab in an existing private window, might be worth noting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

firefoxes open in an existing window for me but could not find anything to make qutebrowser open in an existing window

@teknsl
Copy link
Contributor Author

teknsl commented Jul 11, 2024

i did not try to build and missed the type std::pair<Qstring, Qstring> (sorry). with this it isnt possible to support browsers that need more than one argument to open in an incognito window like qutebrowser. from what i can tell there is only two places that call/use getPrivateSwitch so maybe it wont be too hard to modify but its out of my ability

however i only added qutebrowser while i was already adding browsers, i do not daily drive this so i will remove it

maybe pr should be renamed to reduce scope?

@Mm2PL Mm2PL changed the title private browsing support for more browsers Add Private Window support for Firefox variants Jul 11, 2024
@Mm2PL
Copy link
Collaborator

Mm2PL commented Jul 11, 2024

It's okay to remove qutebrowser. It seems that the private window switch isn't all that good in it anyway.

@Mm2PL Mm2PL changed the title Add Private Window support for Firefox variants Support more firefox variants for incognito link opening Jul 11, 2024
@Mm2PL Mm2PL enabled auto-merge (squash) July 11, 2024 10:13
@Mm2PL
Copy link
Collaborator

Mm2PL commented Jul 11, 2024

Thank you for your contribution.

As a first-time contributor, you can now add yourself to the contributors list that's shown inside the About page in Chatterino.

If you want this, you can open a new PR where you modify the resources/contributors.txt file and add yourself to the list. Make sure to read the comments at the top for instructions.

CHANGELOG.md Outdated Show resolved Hide resolved
@Mm2PL Mm2PL merged commit e2c3823 into Chatterino:master Jul 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants