Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move seventv/bttv event apis to application #5532

Merged
merged 5 commits into from
Aug 8, 2024
Merged

refactor: move seventv/bttv event apis to application #5532

merged 5 commits into from
Aug 8, 2024

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Aug 4, 2024

  • Gracefully quit streamer mode
  • Set Application::instance to nullptr in dtor, allow us to better catch usages of getApp() after Application is destroyed
  • move SeventvEventAPI from TwitchIrcServer to Application
  • move BttvLiveUpdates to Application

github-actions[bot]
github-actions bot reviewed Aug 4, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

mocks/include/mocks/BaseApplication.hpp Show resolved Hide resolved
mocks/include/mocks/BaseApplication.hpp Show resolved Hide resolved
mocks/include/mocks/BaseApplication.hpp Show resolved Hide resolved
mocks/include/mocks/EmptyApplication.hpp Show resolved Hide resolved
mocks/include/mocks/EmptyApplication.hpp Show resolved Hide resolved
mocks/include/mocks/EmptyApplication.hpp Show resolved Hide resolved
mocks/include/mocks/EmptyApplication.hpp Show resolved Hide resolved
mocks/include/mocks/EmptyApplication.hpp Show resolved Hide resolved
mocks/include/mocks/EmptyApplication.hpp Show resolved Hide resolved
mocks/include/mocks/TwitchIrcServer.hpp Show resolved Hide resolved
@pajlada pajlada marked this pull request as ready for review August 8, 2024 12:49
pajlada
pajlada commented Aug 8, 2024
View reviewed changes
Copy link
Member Author

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@pajlada pajlada changed the title chore: more graceful exit refactor: move seventv/bttv event apis to application Aug 8, 2024
@pajlada pajlada merged commit f0802af into master Aug 8, 2024
18 checks passed
@pajlada pajlada deleted the chore/more-gracefully-exit branch August 8, 2024 13:08
@Nerixyz Nerixyz mentioned this pull request Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pajlada