Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: don't force-layout in setChannel #5737

Merged
merged 3 commits into from
Nov 28, 2024
Merged

perf: don't force-layout in setChannel #5737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb9e083
perf: don't force-layout in `setChannel`
Nerixyz Nov 25, 2024
b3745ac
chore: add changelog entry
Nerixyz Nov 25, 2024
df95dea
Merge branch 'master' into perf/dont-force-set-channel
pajlada Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@
- Dev: 7TV's `entitlement.reset` is now explicitly ignored. (#5685)
- Dev: Qt 6.8 and later now default to the GDI fontengine. (#5710)
- Dev: Moved to condition variables when shutting down worker threads. (#5721, #5733)
- Dev: Reduced layouts in channel views when setting a channel. (#5737)

## 2.5.1

Expand Down
2 changes: 1 addition & 1 deletion src/widgets/helper/ChannelView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,7 +1073,7 @@ void ChannelView::setChannel(const ChannelPtr &underlyingChannel)

this->updateID();

this->performLayout();
this->queueLayout();
this->queueUpdate();

// Notifications
Expand Down
Loading