Skip to content

Commit

Permalink
Change own direct-visibility statuses to be in the home feed again (m…
Browse files Browse the repository at this point in the history
…astodon#14711)

And remove highlighting in web UI

Full circle from mastodon#8940
  • Loading branch information
Gargron authored and thenameisnigel-old committed Sep 6, 2020
1 parent 4a722e0 commit f4f73f7
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 25 deletions.
23 changes: 0 additions & 23 deletions app/javascript/styles/mastodon/components.scss
Original file line number Diff line number Diff line change
Expand Up @@ -980,14 +980,6 @@
outline: 0;
background: lighten($ui-base-color, 4%);

.status.status-direct {
background: lighten($ui-base-color, 12%);

&.muted {
background: transparent;
}
}

.detailed-status,
.detailed-status__action-bar {
background: lighten($ui-base-color, 8%);
Expand Down Expand Up @@ -1022,11 +1014,6 @@
margin-top: 8px;
}

&.status-direct:not(.read) {
background: lighten($ui-base-color, 8%);
border-bottom-color: lighten($ui-base-color, 12%);
}

&.light {
.status__relative-time,
.status__visibility-icon {
Expand Down Expand Up @@ -1064,16 +1051,6 @@
}
}

.notification-favourite {
.status.status-direct {
background: transparent;

.icon-button.disabled {
color: lighten($action-button-color, 13%);
}
}
}

.status__relative-time,
.status__visibility-icon,
.notification__relative_time {
Expand Down
2 changes: 1 addition & 1 deletion app/lib/feed_manager.rb
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def populate_feed(account)
aggregate = account.user&.aggregates_reblogs?
timeline_key = key(:home, account.id)

account.statuses.where.not(visibility: :direct).limit(limit).each do |status|
account.statuses.limit(limit).each do |status|
add_to_feed(:home, account.id, status, aggregate)
end

Expand Down
3 changes: 2 additions & 1 deletion app/services/fan_out_on_write_service.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,13 @@ class FanOutOnWriteService < BaseService
def call(status)
raise Mastodon::RaceConditionError if status.visibility.nil?

deliver_to_self(status) if status.account.local?

if status.direct_visibility?
deliver_to_own_conversation(status)
elsif status.limited_visibility?
deliver_to_mentioned_followers(status)
else
deliver_to_self(status) if status.account.local?
deliver_to_followers(status)
deliver_to_lists(status)
end
Expand Down

0 comments on commit f4f73f7

Please sign in to comment.