Read scheduled rewards from core
#1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 4, 2023 12:59
bajtos
reviewed
Dec 5, 2023
|
@patrickwoodhead thank you for the pull request! Can you please use a more descriptive PR title than "1134 refactor"? For example: "refactor scheduled rewards" |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
juliangruber
changed the title
core
juliangruber
requested changes
Dec 7, 2023
Co-authored-by: Julian Gruber <julian@juliangruber.com>
https://github.com/filecoin-station/desktop into 1134-read-scheduled-rewards-from-station-core-metrics
Co-authored-by: Julian Gruber <julian@juliangruber.com>
|
@juliangruber @patrickwoodhead, what's the status of this PR? Are there any changes needed before we can land & release this? |
|
I'm looking into finishing this up now 🙏 |
juliangruber
deleted the
1134-read-scheduled-rewards-from-station-core-metrics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The desktop no longer makes a request to the contract to fetch the scheduled rewards. Instead it gets this info from core.
The balance sent around by the IPC events is now not truncated to 6 decimal places but instead it is the full 18 significant figures of the balance. This leaves it to each of the renderers (UI, tray etc) to decide how they want to format the value.