Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filecoin-station/core@18 #1296

Merged
merged 5 commits into from
Feb 2, 2024
Merged

filecoin-station/core@18 #1296

merged 5 commits into from
Feb 2, 2024

Conversation

juliangruber
Copy link
Member

No description provided.

dependabot bot and others added 3 commits February 1, 2024 02:52
Bumps [@filecoin-station/core](https://github.com/filecoin-station/core) from 17.0.1 to 18.0.0.
- [Release notes](https://github.com/filecoin-station/core/releases)
- [Commits](CheckerNetwork/node@v17.0.1...v18.0.0)

---
updated-dependencies:
- dependency-name: "@filecoin-station/core"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Copy link

socket-security bot commented Feb 2, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@filecoin-station/core@18.1.2 Transitive: environment, eval, filesystem, network, shell, unsafe +246 94.1 MB bajtos, juliangruber

🚮 Removed packages: npm/@filecoin-station/core@17.0.1

View full report↗︎

Copy link

socket-security bot commented Feb 2, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/protobufjs@6.11.4
  • Install script: postinstall
  • Source: node scripts/postinstall

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/protobufjs@6.11.4

this.#online = true
} else if (activity.message === 'SPARK failed reporting retrieval') {
this.#online = false
const firstWord = activity.message.split(' ')[0].toLowerCase()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose to make this a bit more dynamic, as I think it was getting too verbose and too easy to break when iterating on messages. It can produce false results too, so it's not a finished solution, but in my mind an improvement. Happy to follow up on this

@juliangruber juliangruber merged commit 76d4b1b into main Feb 2, 2024
10 of 11 checks passed
@juliangruber juliangruber deleted the update/core-18 branch February 2, 2024 19:55
@juliangruber juliangruber requested a review from bajtos February 2, 2024 19:56
@juliangruber
Copy link
Member Author

@bajtos hindsight please 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant