Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from glif graphql & filfox to Beryx #1357

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

juliangruber
Copy link
Member

As discussed in https://filecoinproject.slack.com/archives/C03PVLW721L/p1709027221851889, we should migrate away from using Glif's GraphQL API. While we're at it, also migrate away from Filfox, as they don't offer an official API.

Don't merge this before we have received permission by Beryx/Zondax to use their API. If they don't give us permission, invalidate the token.

I've tested this PR and the API is smooth and responsive :)

@juliangruber juliangruber requested a review from bajtos February 27, 2024 10:59
@juliangruber
Copy link
Member Author

We got permission 🥳

@juliangruber
Copy link
Member Author

@bajtos hindsight please

@juliangruber juliangruber merged commit 4ddae51 into main Feb 28, 2024
11 checks passed
@juliangruber juliangruber deleted the update/filfox-beryx branch February 28, 2024 08:45
@juliangruber
Copy link
Member Author

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants