Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wallet ui - part 2/2 #334

Merged

Conversation

jopedroliveira
Copy link
Contributor

Part 2 of 2 - UI

This PR implements the Station Wallet Module's UI components, flows, and API calls.
The changes on this PR will only work with #333 this is part 2 of the feature, separated here for readability purposes.

⚠️ Backend: station-config.js and other /main files need attention, as well as some functions tagged with // todo comments

@bajtos bajtos requested a review from juliangruber December 12, 2022 15:45
@jopedroliveira jopedroliveira marked this pull request as ready for review December 12, 2022 16:52
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update this branch, in order to show less redundant changes in the diff viewer?

jopedroliveira and others added 17 commits December 16, 2022 13:37
Co-authored-by: Julian Gruber <julian@juliangruber.com>
Co-authored-by: Julian Gruber <julian@juliangruber.com>
Co-authored-by: Julian Gruber <julian@juliangruber.com>
Co-authored-by: Julian Gruber <julian@juliangruber.com>
Co-authored-by: Julian Gruber <julian@juliangruber.com>
Co-authored-by: Julian Gruber <julian@juliangruber.com>
Co-authored-by: Julian Gruber <julian@juliangruber.com>
Co-authored-by: Julian Gruber <julian@juliangruber.com>
Co-authored-by: Julian Gruber <julian@juliangruber.com>
Co-authored-by: Julian Gruber <julian@juliangruber.com>
Co-authored-by: Julian Gruber <julian@juliangruber.com>
Co-authored-by: Julian Gruber <julian@juliangruber.com>
@jopedroliveira
Copy link
Contributor Author

Could you please update this branch to show fewer changes in the diff viewer?

I rebased this with #333 but didn't improve the diff viewer since this targets feat/wallet.

In order to improve readability, we need to create different branches on this repo following the fork dependency tree, or merge it/review it following the order 332 -> 333 -> 334 -> 335.

@juliangruber juliangruber merged commit 95a8192 into CheckerNetwork:feat/wallet Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants