-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automatically restart to update #931
Conversation
When the Station is running in the tray, and a new version is detected, we immediately trigger "restart to install". The goal is to speed up the adoption of new versions of Station Desktop. Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
That's it. To test it properly we'd have to create a release. I think we can skip this for now |
This change may introduce an endless loop if an update cannot be installed (e.g. because of filesystem permissions problems, as we experienced in the past.)
Possible solution:
@juliangruber WDYT? |
Another option: Only try to update once the app has run for one minute. This should give the user enough time to break the cycle |
Otherwise I agree we need to track some state to prevent this loop |
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Added bdc462c to prevent infinite loop of app restarts. @juliangruber PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! 👏
When the Station is running in the tray, and a new version is detected, we immediately trigger "restart to install".
The goal is to speed up the adoption of new versions of Station Desktop.
Screenshot of the notification:
How I tested the change:
npm run package
open dist/Filecoin\ Station.dmg
$HOME/Library/Logs/Filecoin Station/main.log
contains the new message about restart:Unfortunately, the auto-update failed while verifying the code signature of the new version. I think this could be caused by running a locally-built Station and trying to update to one built by our CI.