Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Docker base image to slim #437

Merged
merged 2 commits into from
May 2, 2024
Merged

Change Docker base image to slim #437

merged 2 commits into from
May 2, 2024

Conversation

zipiju
Copy link
Contributor

@zipiju zipiju commented Apr 30, 2024

Slim shaves about 400MB off the container when installed. It is always better to have smaller images, especially when installing these at the edge on routers and such.

Slim shaves about 400MB off the container when installed. It is always better to have smaller images, especially when installing these at the edge on routers and such.
@juliangruber juliangruber requested a review from bajtos April 30, 2024 06:22
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 if CI passes

@bajtos
Copy link
Member

bajtos commented May 2, 2024

For context: we moved from Alpine to Full distro because Zinnia does not support Alpine yet and Saturn L2 module was not able to run on the Slim version.

See #92

We cannot use node:18-alpine because Zinnia does not support that yet.

I tried to use node:18-slim, but Saturn L2 was not able to start in that system.
The Node.js project recommends to use node:18, so we should be fine. See https://github.com/nodejs/docker-node#image-variants

Now that we are no longer shipping Saturn L2, it makes a lot of sense to switch to Slim version.

Thank you for contributing this improvement, @zipiju! ❤️

@bajtos bajtos enabled auto-merge (squash) May 2, 2024 11:50
@bajtos bajtos merged commit 4a177ae into CheckerNetwork:main May 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants