Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotate Sentry DSN #594

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Rotate Sentry DSN #594

merged 1 commit into from
Sep 10, 2024

Conversation

juliangruber
Copy link
Member

No description provided.

@juliangruber juliangruber requested a review from bajtos September 10, 2024 08:10
@bajtos
Copy link
Member

bajtos commented Sep 10, 2024

FWIW, I have already rotated the token last week and disabled the old one.
See #588

@bajtos
Copy link
Member

bajtos commented Sep 10, 2024

I disabled the old token only yesterday, that's why the old error is still present in the weekly summary.

bajtos
bajtos approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having said that, there is nothing wrong with this PR, we can land it if you like.

@juliangruber juliangruber merged commit f73ebad into main Sep 10, 2024
18 checks passed
@juliangruber juliangruber deleted the update/sentry-dsn-2 branch September 10, 2024 11:40
@juliangruber
Copy link
Member Author

got it! Then this doesn't need to be released now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliangruber @bajtos