Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules: ensure main file also exists #623

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Conversation

juliangruber
Copy link
Member

Trying to fix reported cases of sources/spark/main.js missing, while sources/spark is there.

This is the same path we're checking below - only if the main file main.js exists, consider the module as functional. This is still not great but should fix some cases. In the future, use hashes to check validity of all files on disk.

@juliangruber juliangruber requested a review from bajtos November 10, 2024 16:51
@juliangruber juliangruber merged commit 5e33bf5 into main Nov 10, 2024
18 checks passed
@juliangruber juliangruber deleted the fix/stat-main-file branch November 10, 2024 16:55
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants