Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade Deno core and extensions #97

Merged
merged 4 commits into from
Mar 9, 2023
Merged

feat: upgrade Deno core and extensions #97

merged 4 commits into from
Mar 9, 2023

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Mar 9, 2023

Upgrade Deno crates:

  • deno_core from 0.171.0 to 0.173.0
  • deno_runtime from 0.97.0 to 0.99.0

Rework our internal modules to use the new ES module style (see denoland/deno#17648 and and denoland/deno#17683)

The changes are best reviewed with whitespace-changes ignored.

Rework the way how we call async ops - see denoland/deno#17899

Disable Windows support for the time being because GitHub Action Windows runners don't have enough disk space for building Zinnia 😱 I opened #99 to investigate and fix this problem.

See #73

@bajtos bajtos changed the title feat: upgrade deno internals feat: upgrade Deno core and extensions Mar 9, 2023
Upgrade Deno crates:
- `deno_core` from `0.171.0` to `0.173.0`
- `deno_runtime` from `0.97.0` to `0.99.0`

Rework our internal modules to use the new ES module style.

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
bajtos added 2 commits March 9, 2023 14:38
Building Zinnia exhausts all disk space available on Windows.

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos bajtos requested a review from juliangruber March 9, 2023 13:40
@bajtos bajtos marked this pull request as ready for review March 9, 2023 13:40
@bajtos
Copy link
Member Author

bajtos commented Mar 9, 2023

Disable Windows support for the time being because GitHub Action Windows runners don't have enough disk space for building Zinnia 😱

I opened a follow-up issue here: #99

@bajtos bajtos mentioned this pull request Mar 9, 2023
9 tasks
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While that probably wasn't the most fun exercise, I'm happy that such a fundamental upgrade wasn't bad for us, and now more confident that this is a good direction

.github/workflows/ci.yaml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
Co-authored-by: Julian Gruber <julian@juliangruber.com>
@bajtos bajtos enabled auto-merge (squash) March 9, 2023 19:49
@bajtos bajtos merged commit 865e436 into main Mar 9, 2023
@bajtos bajtos deleted the upgrade-deno branch March 9, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants