fix: jfrog token is not detected #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binyamin2
changed the title
binyamin2
changed the title
baruchiro
approved these changes
Aug 16, 2023
|
Thank's :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #164
Proposed Changes
-Changing the version of "gitleaks" dependency to commit "add JFrog API and Identity keys #1233"
-Add tests for Jfrog ( I take it from the branch "missing-secrets")
-Update the functions of "Slack" in secrets.go (I didn't know what is the appropriate tag for each one)
I submit this contribution under the Apache-2.0 license.