TF plan scanning only scans root and not “child” modules? #5305

hazanosher · 2022-05-04T13:08:59Z

hazanosher
May 4, 2022

It looks like the tf plan scan implementation scans the direct resources under root module without “child” modules. Is this intentional? Wondering what were the considerations and if you can consider also scanning the child modules recursively.

Here we convert only plan.PlannedValues.RootModule.Resources into model.Document, while ignoring plan.PlannedValues.RootModule.ChildModules

func readPlan(plan *hcl_plan.Plan) model.Document {
	modRes := readModule(plan.PlannedValues.RootModule.Resources)

	doc := model.Document{}

	kp := KicsPlan{
		Resource: modRes,
	}
	tmpDocBytes, err := json.Marshal(kp)
	if err != nil {
		return model.Document{}
	}
	err = json.Unmarshal(tmpDocBytes, &doc)
	if err != nil {
		return model.Document{}
	}

	return doc
}

// readModule will iterate over all planned_value getting the information required
func readModule(resources []*hcl_plan.StateResource) map[string]KicsPlanResource {
	convRes := make(map[string]KicsPlanResource)
	// initialize all the types interfaces
	for _, resource := range resources {
		convNamedRes := make(map[string]KicsPlanNamedResource)
		convRes[resource.Type] = convNamedRes
	}
	// fill in all the types interfaces
	for _, resource := range resources {
		convRes[resource.Type][resource.Name] = resource.AttributeValues
	}
	return convRes
}