Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): corrected "S3 Bucket Should Have Bucket Policy" approach #4319

Merged

Conversation

rafaela-soares
Copy link
Contributor

Closes #4303

Proposed Changes

  • Corrected "S3 Bucket Should Have Bucket Policy" approach: should be check if Resources.%s.Properties.BucketName or Resources.[%s] is not the same as an AWS::S3::BucketPolicy Bucket

I submit this contribution under the Apache-2.0 license.

@rafaela-soares rafaela-soares added query New query feature cloudformation CloudFormation query aws PR related with AWS Cloud labels Sep 29, 2021
@rafaela-soares rafaela-soares added this to the Quality milestone Sep 29, 2021
@rafaela-soares rafaela-soares self-assigned this Sep 29, 2021
@kicsbot
Copy link
Contributor

kicsbot commented Sep 29, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Sep 29, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 4 vulnerabilities
High 0 High
Medium 0 Medium
Low 4 Low
Info 0 Info

Violation Summary

No policy violation found

Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 70178fe into master Sep 29, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the feature/correct_s3_bucket_should_have_bucket_policy branch September 29, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws PR related with AWS Cloud cloudformation CloudFormation query query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"S3 Bucket Should Have Bucket Policy" Does Not Handle !Ref Properly
3 participants