Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(terraform): Added Ignore lines by comments to terraform #4480

Merged
merged 1 commit into from
Nov 5, 2021
Merged

feat(terraform): Added Ignore lines by comments to terraform #4480

merged 1 commit into from
Nov 5, 2021

Conversation

joaoReigota1
Copy link
Collaborator

@joaoReigota1 joaoReigota1 commented Nov 4, 2021 •
edited
Loading

Signed-off-by: João Reigota joao.reigota@checkmarx.com

#4420 #4419

Proposed Changes

  • Users can now ignore lines by comments in the original file
  • Simplified tests in the engine to prevent timeouts
  • lines containing comments are now excluded as well for terraform
  • this feature should only be enabled when all parsers support this feature

I submit this contribution under the Apache-2.0 license.

@joaoReigota1 joaoReigota1 added feature New feature terraform Terraform query go Pull requests that update Go code labels Nov 4, 2021
@joaoReigota1 joaoReigota1 added this to the Core Engineering milestone Nov 4, 2021
@joaoReigota1 joaoReigota1 requested a review from a team November 4, 2021 19:27
@joaoReigota1 joaoReigota1 self-assigned this Nov 4, 2021
@kicsbot
Copy link
Contributor

kicsbot commented Nov 4, 2021

Scan submitted to Checkmarx

@joaoReigota1 joaoReigota1 force-pushed the joaoReigota1/issue4420 branch from 59f154f to da1bd3f Compare November 4, 2021 19:27
@kicsbot
Copy link
Contributor

kicsbot commented Nov 4, 2021

Scan not submitted to Checkmarx due to existing Active scan for the same project.

@kicsbot
Copy link
Contributor

kicsbot commented Nov 4, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 4 vulnerabilities
High 0 High
Medium 0 Medium
Low 4 Low
Info 0 Info

Violation Summary

No policy violation found

@joaoReigota1 joaoReigota1 force-pushed the joaoReigota1/issue4420 branch 2 times, most recently from 52e03ad to 9e25b97 Compare November 5, 2021 09:53
@joaoReigota1
feat(terraform): Added Ignore lines by comments to terraform
7acbd90 
Signed-off-by: João Reigota <joao.reigota@checkmarx.com>
@joaoReigota1 joaoReigota1 force-pushed the joaoReigota1/issue4420 branch from 9e25b97 to 7acbd90 Compare November 5, 2021 11:19
felipe-avelar
felipe-avelar approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rafaela-soares
rafaela-soares approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaoReigota1 joaoReigota1 merged commit 6211c7f into master Nov 5, 2021
@joaoReigota1 joaoReigota1 deleted the joaoReigota1/issue4420 branch November 5, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaela-soares rafaela-soares rafaela-soares approved these changes

@felipe-avelar felipe-avelar felipe-avelar approved these changes

Assignees

@joaoReigota1 joaoReigota1

Labels
feature New feature go Pull requests that update Go code terraform Terraform query
Projects
None yet
Milestone
Core Engineering
Development

Successfully merging this pull request may close these issues.
4 participants
@joaoReigota1 @kicsbot @rafaela-soares @felipe-avelar