Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(report): fixed bug with invalid startLine on sarif report #4483

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

felipe-avelar
Copy link
Contributor

Signed-off-by: Felipe Avelar felipe.avelar@checkmarx.com

Closes #4431

Proposed Changes

  • Now, when a line is less than 1, will point to file's first line

I submit this contribution under the Apache-2.0 license.

Signed-off-by: Felipe Avelar <felipe.avelar@checkmarx.com>
@felipe-avelar felipe-avelar added bug Something isn't working go Pull requests that update Go code labels Nov 5, 2021
@felipe-avelar felipe-avelar added this to the Reporting milestone Nov 5, 2021
@felipe-avelar felipe-avelar self-assigned this Nov 5, 2021
@kicsbot
Copy link
Contributor

kicsbot commented Nov 5, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Nov 5, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 4 vulnerabilities
High 0 High
Medium 0 Medium
Low 4 Low
Info 0 Info

Violation Summary

No policy violation found

Copy link
Collaborator

@nunoocx nunoocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nunoocx nunoocx merged commit f7c6b80 into master Nov 5, 2021
@nunoocx nunoocx deleted the fix/invalid-start-line-value-sarif branch November 5, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SARF report output report violate specification setting startLine to -1
3 participants