Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pre-commit hook #4520

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Conversation

paulopontesm
Copy link
Contributor

@paulopontesm paulopontesm commented Nov 15, 2021

Closes #

I use pre-commit a lot to check for stuff before pushing it to the repo, and I was missing kics integration.

One thing that I noticed is that even though I'm excluding .terraform, I think kics itself is scanning them because it scans terraform modules by default, but I'm not sure. Any thoughts?

Proposed Changes

  • Add pre-commit integration

I submit this contribution under the Apache-2.0 license.

@kicsbot
Copy link
Contributor

kicsbot commented Nov 15, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Nov 15, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 4 vulnerabilities
High 0 High
Medium 0 Medium
Low 4 Low
Info 0 Info

Violation Summary

No policy violation found

Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nunoocx
Copy link
Collaborator

nunoocx commented Nov 22, 2021

@paulopontesm in order for this page to appear in the docs site, can you please add an entry below the following line?

- Badge: BADGE.md

and add a link to it also in the integrations.md file? https://github.com/Checkmarx/kics/blob/master/docs/integrations.md

Copy link
Collaborator

@nunoocx nunoocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment in the conversation tab

@felipe-avelar felipe-avelar dismissed nunoocx’s stale review November 24, 2021 10:08

Will be fixed on other PR

@felipe-avelar felipe-avelar merged commit b13a044 into Checkmarx:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants