Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(parser): support of YAML alias #4659

Merged
merged 3 commits into from
Jan 18, 2022
Merged

feat(parser): support of YAML alias #4659

merged 3 commits into from
Jan 18, 2022

Conversation

rafaela-soares
Copy link
Contributor

Closes #4630

Proposed Changes

  • Support of YAML alias

I submit this contribution under the Apache-2.0 license.

@rafaela-soares rafaela-soares added the go Pull requests that update Go code label Jan 3, 2022
@rafaela-soares rafaela-soares self-assigned this Jan 3, 2022
@kicsbot
Copy link
Contributor

kicsbot commented Jan 3, 2022

Scan submitted to Checkmarx

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2022

kics-logo

KICS version: v1.4.8

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 53
Queries failed to execute placeholder 0
Execution time placeholder 1

@rafaela-soares rafaela-soares mentioned this pull request Jan 3, 2022
Closed
@kicsbot
Copy link
Contributor

kicsbot commented Jan 3, 2022

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 4 vulnerabilities
High 0 High
Medium 0 Medium
Low 4 Low
Info 0 Info

Violation Summary

No policy violation found

joaoReigota1
joaoReigota1 requested changes Jan 17, 2022
View reviewed changes
pkg/model/model_yaml.go Outdated Show resolved Hide resolved
@rafaela-soares rafaela-soares force-pushed the feat/support_yaml_alias_ branch from 6dd0513 to 019d113 Compare January 17, 2022 18:08
@kicsbot
Copy link
Contributor

kicsbot commented Jan 17, 2022

Scan not submitted to Checkmarx due to existing Active scan for the same project.

joaoReigota1
joaoReigota1 approved these changes Jan 18, 2022
View reviewed changes
Copy link
Collaborator

@joaoReigota1 joaoReigota1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaoReigota1 joaoReigota1 merged commit 795a270 into master Jan 18, 2022
@joaoReigota1 joaoReigota1 deleted the feat/support_yaml_alias_ branch January 18, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaoReigota1 joaoReigota1 joaoReigota1 approved these changes

Assignees

@rafaela-soares rafaela-soares

Labels
go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ansible: yaml anchor and alias is not detected
3 participants
@rafaela-soares @kicsbot @joaoReigota1