Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): fix terraform query for ingress/egress description #4736

Merged

Conversation

lipeavelar
Copy link
Contributor

Signed-off-by: Felipe Avelar felipe.avelar@outlook.com

Closes #4691

Proposed Changes

  • update ingress/egress description terraform query to check when there are multiple ingress/egress blocks

I submit this contribution under the Apache-2.0 license.

@kicsbot
Copy link
Contributor

kicsbot commented Jan 22, 2022

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Jan 22, 2022

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 4 vulnerabilities
High 0 High
Medium 0 Medium
Low 4 Low
Info 0 Info

Violation Summary

No policy violation found

Signed-off-by: Felipe Avelar <felipe.avelar@outlook.com>
@lipeavelar lipeavelar force-pushed the fix/query-aws-false-positive branch from 84e17fc to 96a4d6e Compare January 22, 2022 08:18
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rafaela-soares rafaela-soares added query New query feature terraform Terraform query bug Something isn't working labels Jan 24, 2022
@rafaela-soares rafaela-soares added the community Community contribution label Jan 24, 2022
@joaoReigota1 joaoReigota1 merged commit 07eb922 into Checkmarx:master Jan 24, 2022
@lipeavelar lipeavelar deleted the fix/query-aws-false-positive branch January 24, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community Community contribution query New query feature terraform Terraform query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform AWS rule "Security Group Rules Without Description" giving false positive?
4 participants