Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(golang): fixed golang data races and make file #4741

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

joaoReigota1
Copy link
Collaborator

Signed-off-by: João Reigota joao.reigota@checkmarx.com

Proposed Changes

  • fixed Golang data races caused by analyzer
  • fixed make file dev tags
  • changed e2e to run with dev tags

I submit this contribution under the Apache-2.0 license.

Signed-off-by: João Reigota <joao.reigota@checkmarx.com>
@joaoReigota1 joaoReigota1 added bug Something isn't working CI PR related with GitHub Actions CI process labels Jan 24, 2022
@joaoReigota1 joaoReigota1 self-assigned this Jan 24, 2022
@kicsbot
Copy link
Contributor

kicsbot commented Jan 24, 2022

Scan submitted to Checkmarx

@github-actions
Copy link
Contributor

kics-logo

KICS version: v1.4.8

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 53
Queries failed to execute placeholder 0
Execution time placeholder 1

@kicsbot
Copy link
Contributor

kicsbot commented Jan 24, 2022

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 4 vulnerabilities
High 0 High
Medium 0 Medium
Low 4 Low
Info 0 Info

Violation Summary

No policy violation found

Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaoReigota1 joaoReigota1 merged commit 5a157ec into master Jan 24, 2022
@joaoReigota1 joaoReigota1 deleted the fix_data_races branch January 24, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI PR related with GitHub Actions CI process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants