Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): Fix searchKey and additional resource kinds in volume_mount_with_os_directory_write_permissions k8s rule #4889

Merged
merged 2 commits into from
Mar 4, 2022

Conversation

Churro
Copy link
Contributor

@Churro Churro commented Feb 27, 2022

Proposed Changes

  • Fix typo in searchKey preventing successful search results
  • Changed resource.spec to getSpecInfo in order to enable further resource kinds

I submit this contribution under the Apache-2.0 license.

…nt_with_os_directory_write_permissions k8s rule
@kicsbot
Copy link
Contributor

kicsbot commented Feb 27, 2022

Scan submitted to Checkmarx

Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Another great observation and refactor, @Churro 🚀 Thank you so much!

@joaoReigota1 joaoReigota1 merged commit f25c8cd into Checkmarx:master Mar 4, 2022
@rafaela-soares rafaela-soares added the community Community contribution label Mar 16, 2022
@rafaela-soares rafaela-soares added the query New query feature label Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants