fix(query): add a missing SSE way for SQS #4984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Scan submitted to Checkmarx |
|
Cx-SAST SummaryTotal of 5 vulnerabilities Violation SummaryNo policy violation found |
jycamier
force-pushed
the
query/fix_add_missing_sse_way_for_sqs
branch
from
a9b1855
to
9e84019
Compare
rafaela-soares
suggested changes
Mar 15, 2022
There was a problem hiding this comment.
Hello, @jycamier!
Such a great observation and contribution! Thank you so much 🚀
Please, take a look at the minor suggestions:
Co-authored-by: Rafaela Soares <rafaela.soares@checkmarx.com>
|
Hello @rafaela-soares I've updated / accepted your suggestion change. |
rafaela-soares
approved these changes
Mar 15, 2022
There was a problem hiding this comment.
LGTM 🚀
Thank you so much for the feedback, @jycamier!
We are very grateful for your amazing contributions, suggestions and iterations! 😊
Let's continue to Keep Infrastructure as Code (more) Secure together 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
From the documentation, there are 2 way to add SSE on a AWS SQS :
Currently, the query
terraform/aws/sqs_with_sse_disabledcheck only SSE-KMS.Proposed Changes
terraform/aws/sqs_with_sse_disabledto check if one of the 2 ways is set and not nullI submit this contribution under the Apache-2.0 license.