Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(secrets regex): added "Avoiding Secrets Manager arn" #5048

Merged
merged 2 commits into from
Mar 28, 2022
Merged

fix(secrets regex): added "Avoiding Secrets Manager arn" #5048

merged 2 commits into from
Mar 28, 2022

Conversation

rafaela-soares
Copy link
Contributor

Closes #5042

Proposed Changes

  • added "Avoiding Secrets Manager arn"

I submit this contribution under the Apache-2.0 license.

@rafaela-soares rafaela-soares added the bug Something isn't working label Mar 25, 2022
@rafaela-soares rafaela-soares self-assigned this Mar 25, 2022
@kicsbot
Copy link
Contributor

kicsbot commented Mar 25, 2022

Scan submitted to Checkmarx

@rafaela-soares rafaela-soares mentioned this pull request Mar 25, 2022
Closed
@kicsbot
Copy link
Contributor

kicsbot commented Mar 25, 2022

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 5 vulnerabilities
High 0 High
Medium 0 Medium
Low 5 Low
Info 0 Info

Violation Summary

No policy violation found

joaoReigota1
joaoReigota1 approved these changes Mar 28, 2022
View reviewed changes
Copy link
Collaborator

@joaoReigota1 joaoReigota1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaoReigota1 joaoReigota1 merged commit daeae25 into master Mar 28, 2022
@joaoReigota1 joaoReigota1 deleted the fix/generic_secret_regex branch March 28, 2022 11:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaoReigota1 joaoReigota1 joaoReigota1 approved these changes

Assignees

@rafaela-soares rafaela-soares

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Password and Secrets: false positive using Secrets manager
3 participants
@rafaela-soares @kicsbot @joaoReigota1