Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(Query): Renamed folder and query, changed query description #5173

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Fix(Query): Renamed folder and query, changed query description #5173

merged 1 commit into from
Apr 12, 2022

Conversation

cxAndreFelicidade
Copy link
Contributor

@cxAndreFelicidade cxAndreFelicidade commented Apr 11, 2022 •
edited by rafaela-soares
Loading

Closes #5087

Proposed Changes

  • As noted in issue 5087, query name and description were changed, as well as folder name.

I submit this contribution under the Apache-2.0 license.

@cxAndreFelicidade cxAndreFelicidade added bug Something isn't working query New query feature good first issue Community: beginner-friendly issues labels Apr 11, 2022
@cxAndreFelicidade cxAndreFelicidade added this to the bug milestone Apr 11, 2022
@cxAndreFelicidade cxAndreFelicidade self-assigned this Apr 11, 2022
@kicsbot
Copy link
Contributor

kicsbot commented Apr 11, 2022

Scan submitted to Checkmarx

@cxAndreFelicidade cxAndreFelicidade mentioned this pull request Apr 11, 2022
Closed
@kicsbot
Copy link
Contributor

kicsbot commented Apr 11, 2022

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 5 vulnerabilities
High 0 High
Medium 0 Medium
Low 5 Low
Info 0 Info

Violation Summary

No policy violation found

rafaela-soares
rafaela-soares approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@joaorufi joaorufi merged commit bd3ecb9 into master Apr 12, 2022
@joaorufi joaorufi deleted the issue/5087 branch April 12, 2022 00:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaela-soares rafaela-soares rafaela-soares approved these changes

@joaorufi joaorufi joaorufi approved these changes

@joaoReigota1 joaoReigota1 Awaiting requested review from joaoReigota1

Assignees

@cxAndreFelicidade cxAndreFelicidade

Labels
bug Something isn't working good first issue Community: beginner-friendly issues query New query feature
Projects
None yet
Milestone
bug
Development

Successfully merging this pull request may close these issues.

queryName is not accurate for id "227c2f58-70c6-4432-8e9a-a89c1a548cf5"
4 participants
@cxAndreFelicidade @kicsbot @rafaela-soares @joaorufi