Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): Api Gateway Without Content Encoding on Terraform platform #5227

Merged
merged 2 commits into from
Apr 22, 2022
Merged

fix(query): Api Gateway Without Content Encoding on Terraform platform #5227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d463dd
fix query name
joaorufi Apr 21, 2022
144e941
fix result
joaorufi Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ay_without_content_encoding/metadata.json → ...ay_with_invalid_compression/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"id": "ed35928e-195c-4405-a252-98ccb664ab7b",
"queryName": "API Gateway Without Content Encoding",
"queryName": "API Gateway With Invalid Compression",
"severity": "MEDIUM",
"category": "Encryption",
"descriptionText": "Enable Content Encoding through the attribute 'minimum_compression_size'. This value should be greater than -1 and smaller than 10485760",
"descriptionText": "Attribute 'minimum_compression_size' should be set and it's value should be greater than -1 and smaller than 10485760.",
"descriptionUrl": "https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/api_gateway_rest_api",
"platform": "Terraform",
"descriptionID": "fc02b8db",
Expand Down
4 changes: 2 additions & 2 deletions ...teway_without_content_encoding/query.rego → ...teway_with_invalid_compression/query.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ CxPolicy[result] {
"documentId": input.document[i].id,
"searchKey": sprintf("aws_api_gateway_rest_api[%s]", [name]),
"issueType": "MissingAttribute",
"keyExpectedValue": "Attribute 'minimum_compression_size' is set, greater than -1 and smaller than 10485760",
"keyExpectedValue": "Attribute 'minimum_compression_size' to be set and have a value greater than -1 and smaller than 10485760",
"keyActualValue": "Attribute 'minimum_compression_size' is undefined",
}
}
Expand All @@ -25,7 +25,7 @@ CxPolicy[result] {
"documentId": input.document[i].id,
"searchKey": sprintf("aws_api_gateway_rest_api[%s].minimum_compression_size", [name]),
"issueType": "IncorrectValue",
"keyExpectedValue": "Attribute 'minimum_compression_size' is set, greater than -1 and smaller than 10485760",
"keyExpectedValue": "Attribute 'minimum_compression_size' to be greater than -1 and smaller than 10485760",
"keyActualValue": sprintf("Attribute 'minimum_compression_size' is %d", [resource.minimum_compression_size]),
}
}
0 ...without_content_encoding/test/negative.tf → ...with_invalid_compression/test/negative.tf
View file
Open in desktop
File renamed without changes.
0 ...without_content_encoding/test/positive.tf → ...with_invalid_compression/test/positive.tf
View file
Open in desktop
File renamed without changes.
17 changes: 17 additions & 0 deletions ...ies/terraform/aws/api_gateway_with_invalid_compression/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
[
{
"queryName": "API Gateway With Invalid Compression",
"severity": "MEDIUM",
"line": 1
},
{
"queryName": "API Gateway With Invalid Compression",
"severity": "MEDIUM",
"line": 17
},
{
"queryName": "API Gateway With Invalid Compression",
"severity": "MEDIUM",
"line": 28
}
]
17 changes: 0 additions & 17 deletions ...ies/terraform/aws/api_gateway_without_content_encoding/test/positive_expected_result.json
View file
Open in desktop

This file was deleted.