Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(masked_secrets): Mask Secrets in All Vulnerability Preview #5949

Merged
merged 11 commits into from
Oct 19, 2022

Conversation

cxMiguelSilva
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva commented Oct 18, 2022

Closes #5850

Proposed Changes

  • Mask Secrets in All Vulnerability Preview

I submit this contribution under the Apache-2.0 license.

@cxMiguelSilva cxMiguelSilva added bug Something isn't working go Pull requests that update Go code labels Oct 18, 2022
@cxMiguelSilva cxMiguelSilva self-assigned this Oct 18, 2022
@cxMiguelSilva cxMiguelSilva marked this pull request as draft October 18, 2022 11:13
pkg/kics/service.go Outdated Show resolved Hide resolved
@cxMiguelSilva cxMiguelSilva marked this pull request as ready for review October 18, 2022 14:31
rafaela-soares
rafaela-soares previously approved these changes Oct 18, 2022
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rafaela-soares rafaela-soares merged commit a52e458 into master Oct 19, 2022
@rafaela-soares rafaela-soares deleted the fix/5850 branch October 19, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Masked Secrets - it works but...
2 participants