Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): fix and align queries #6154

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Conversation

roi-orca
Copy link
Contributor

@roi-orca roi-orca commented Feb 9, 2023

Proposed Changes
fix and align queries

Queries:
Launch Configuration Is Not Encrypted
Cloudfront Viewer Protocol Policy Allows HTTP
HPA Targets Invalid Object

I submit this contribution under the Apache-2.0 license.

@roi-orca roi-orca marked this pull request as ready for review February 9, 2023 14:19
@roi-orca
Copy link
Contributor Author

@cxMiguelSilva can you please review my changes?
Do you know why the integration tests failed?
thanks!

Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @roi-orca,
Thank you for another amazing contribution!
The proposed changes LGTM
Regarding the integration tests, there was no reason for them to fail. Sometimes it occurs. We just need to retrigger it.

@cxMiguelSilva cxMiguelSilva merged commit be501e0 into Checkmarx:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants