Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): fix ssl reference in queryname for cloud sql #6818

Merged
merged 3 commits into from
Nov 30, 2023
Merged

fix(query): fix ssl reference in queryname for cloud sql #6818

merged 3 commits into from
Nov 30, 2023

Conversation

bbbbbrie
Copy link
Contributor

@bbbbbrie bbbbbrie commented Nov 29, 2023

Proposed Changes

  • Adjust 'SLL' to 'SSL' in three queries

📓 Notes

I was testing GitLab's Infrastructure as Code scanning with TerraGoat and noticed that one of the vulnerabilities that was detected said:

Cloud SQL Database Instance should have SLL enabled

The identifier links to require_ssl and the Description said:

'settings.ip_configuration.require_ssl' is undefined or null

It looks like the queryName has included 'SLL' instead of 'SSL' since https://github.com/Checkmarx/kics/pull/4693/files.

This PR adjusts the queryName in three queries.

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added community Community contribution query New query feature terraform Terraform query labels Nov 29, 2023
@bbbbbrie bbbbbrie changed the title Draft: ✨ Change 'SLL' to 'SSL' in queryName for Cloud SQL ✨ Change 'SLL' to 'SSL' in queryName for Cloud SQL Nov 29, 2023
@bbbbbrie bbbbbrie changed the title ✨ Change 'SLL' to 'SSL' in queryName for Cloud SQL docs: change 'SLL' to 'SSL' in queryName for Cloud SQL Nov 30, 2023
@bbbbbrie bbbbbrie changed the title docs: change 'SLL' to 'SSL' in queryName for Cloud SQL style: change 'SLL' to 'SSL' in queryName for Cloud SQL Nov 30, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 30, 2023
@bbbbbrie bbbbbrie changed the title style: change 'SLL' to 'SSL' in queryName for Cloud SQL style: fix ssl reference in queryname for cloud sql Nov 30, 2023
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Nov 30, 2023
@bbbbbrie bbbbbrie changed the title style: fix ssl reference in queryname for cloud sql fix(query): fix ssl reference in queryname for cloud sql Nov 30, 2023
@bbbbbrie
Copy link
Contributor Author

@gabriel-cx @cxMiguelSilva 🌊 Hello there! Would one of you be the right person to review this PR? Thanks! 🐈‍⬛

@gabriel-cx gabriel-cx merged commit 66cbf9c into Checkmarx:master Nov 30, 2023
31 of 41 checks passed
@bbbbbrie bbbbbrie deleted the brie-adjust-cloud-sql-query branch November 30, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution query New query feature terraform Terraform query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants