-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scanner): parallel scanning #6833
Conversation
428fdf3
to
297946d
Compare
Hi @liorj-orca , Sorry for the late reply and thank you very much for this amazing contribution! We plan to give you more feedback during this week. |
Hello @liorj-orca In the name of the KICS Team I would like to thank you very much for this contribution, after some consideration we decided to move forward with this PR, we see only 4 things that need to be done and intend on doing it on our side before passing the pr to QA. Creation of 3 e2e tests (covering the cases of self detect, sequential, and user inputted) As soon as this is ready it will be passed to QA and it should be merged. 🚀 💪 Best Regards, KICS Team |
Closes #6583
Allowing end-users to control the level of parallelism they would like to use as part of their scan.
By default, the new flag would be "disabled" as there will be only one worker.
In case the user would like to auto-detect parallelism - we would set the number of workers according to GONUMPROCS.
some future job that can be done around this, is trying to run the analyzing of files(where we decide which files to scan and of which type) in the same way.
I submit this contribution under the Apache-2.0 license.