Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): cloud formation api gateway access logging disabled #6863

Merged
merged 17 commits into from
Feb 26, 2024

Conversation

JulioSCX
Copy link
Contributor

Proposed Changes

  • Query
  • Tests
  • Expected results

I submit this contribution under the Apache-2.0 license.

Copy link

gitguardian bot commented Jan 30, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9419039 Triggered Username Password 8ac0687 assets/queries/cloudFormation/aws/api_gateway_access_logging_disabled/test/negative2.json View secret
9419039 Triggered Username Password c54628a assets/queries/cloudFormation/aws/api_gateway_access_logging_disabled/test/negative2.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@github-actions github-actions bot added feature New feature query New query feature labels Jan 30, 2024
Copy link
Contributor

github-actions bot commented Jan 30, 2024

kics-logo

KICS version: v1.7.12

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

pereiramarco011
pereiramarco011 previously approved these changes Feb 7, 2024
Copy link
Contributor

@pereiramarco011 pereiramarco011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, left a couple easy things for better code organization 😄

Copy link
Contributor

@pereiramarco011 pereiramarco011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@asofsilva asofsilva merged commit be96e52 into master Feb 26, 2024
22 checks passed
@asofsilva asofsilva deleted the kics-1145 branch February 26, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants