Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(warning): updated warnings for line detection failure #6906

Merged
merged 6 commits into from
Mar 15, 2024
Merged

feat(warning): updated warnings for line detection failure #6906

merged 6 commits into from
Mar 15, 2024

Conversation

EduardoSemanas
Copy link
Contributor

Proposed Changes

  • Warning

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added the feature New feature label Feb 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2024 •
edited
Loading

kics-logo

KICS version: v1.7.13

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

pereiramarco011
pereiramarco011 suggested changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@pereiramarco011 pereiramarco011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few simplifications of the code

What do you think?

pkg/detector/helm/helm_detect.go Show resolved Hide resolved
pkg/detector/default_detect.go Show resolved Hide resolved
pereiramarco011
pereiramarco011 previously approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@pereiramarco011 pereiramarco011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@asofsilva asofsilva merged commit 6b9ec14 into master Mar 15, 2024
21 checks passed
@asofsilva asofsilva deleted the kics-1312 branch March 15, 2024 15:31
@BrewTestBot BrewTestBot mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxMiguelSilva cxMiguelSilva cxMiguelSilva approved these changes

@pereiramarco011 pereiramarco011 pereiramarco011 left review comments

@gabriel-cx gabriel-cx Awaiting requested review from gabriel-cx

@asofsilva asofsilva Awaiting requested review from asofsilva

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EduardoSemanas @cxMiguelSilva @pereiramarco011 @asofsilva @JoaoAtGit