Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(query): add CWE information to volume_has_sensitive_host_directory #7153

Merged
merged 12 commits into from
Sep 19, 2024

Conversation

julianthome
Copy link
Contributor

** Reason for Proposed Changes**

  • CWE information for the query was missing

** Proposed Changes**

  • Adding 668 as Exposure of Resource to Wrong Sphere seems the best fit covering both confidentiality and integrity concerns.

I submit this contribution under the Apache-2.0 license.

Adding 668 as Exposure of Resource to Wrong Sphere seems the best fit covering both confidentiality and integrity concerns.
@julianthome julianthome requested a review from a team as a code owner June 25, 2024 12:18
@github-actions github-actions bot added community Community contribution query New query feature labels Jun 25, 2024
@julianthome julianthome changed the title Add CWE information Add CWE information to volume_has_sensitive_host_directory Jun 25, 2024
@julianthome julianthome changed the title Add CWE information to volume_has_sensitive_host_directory update(query): add CWE information to volume_has_sensitive_host_directory Jun 25, 2024
Copy link
Contributor

@ArturRibeiro-CX ArturRibeiro-CX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @julianthome,
Thanks for your the contribution!
At the moment, the query metadata does not have 2 required fields, which is causing the e2e tests to fail, as you can see in the actions pipeline below.
Can you kindly add oldSeverity and cloudProvider fields to the metadata, like so:

(other query's metadata fields)
"descriptionID": "8361cc0a",
"oldSeverity": "HIGH",
"cloudProvider": "common",
"cwe": "668"
}
As soon as you do, I'll approve the PR.

Best regards.

@julianthome
Copy link
Contributor Author

Thanks a lot @ArturRibeiro-CX ... would you mind re-checking the update. Are the changes acceptable?

Copy link
Contributor

@ArturRibeiro-CX ArturRibeiro-CX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @julianthome,
Thanks for you contribution, those changes are enough.
We'll merge this PR as soon as possible.
Best regards.

Copy link

gitguardian bot commented Aug 19, 2024

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
4266030 Triggered Generic Password b711135 assets/queries/common/passwords_and_secrets/test/positive8.json View secret
4266030 Triggered Generic Password b711135 assets/queries/common/passwords_and_secrets/test/positive8.json View secret
4266030 Triggered Generic Password b711135 assets/queries/common/passwords_and_secrets/test/positive8.json View secret
4266030 Triggered Generic Password b711135 assets/queries/common/passwords_and_secrets/test/positive8.json View secret
4266006 Triggered Generic Password b711135 assets/queries/common/passwords_and_secrets/test/negative32.yaml View secret
4266006 Triggered Generic Password b711135 assets/queries/common/passwords_and_secrets/test/negative42.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@ArturRibeiro-CX ArturRibeiro-CX merged commit 4577b22 into Checkmarx:master Sep 19, 2024
26 checks passed
@ArturRibeiro-CX
Copy link
Contributor

Hi @julianthome,
Just to let you know that your PR was merged today.
Thanks for your contribution to KICS.

Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants