Add Suport for google_secret_manager_secret_version to TGC (GoogleC…

…loudPlatform#10652)
Cheriit · Jun 4, 2024 · 9ff82b0 · 9ff82b0
1 parent 1a4c90f
commit 9ff82b0
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/mmv1/templates/tgc/resource_converters.go.erb b/mmv1/templates/tgc/resource_converters.go.erb
@@ -79,6 +79,7 @@ func ResourceConverters() map[string][]cai.ResourceConverter {
 		"google_spanner_instance_iam_binding":             {spanner.ResourceConverterSpannerInstanceIamBinding()},
 		"google_spanner_instance_iam_member":              {spanner.ResourceConverterSpannerInstanceIamMember()},
 		"google_project_service":                          {resourceConverterServiceUsage()},
+		"google_secret_manager_secret_version": 		   {secretmanager.ResourceConverterSecretManagerSecretVersion()},
 		"google_pubsub_lite_reservation":                  {pubsublite.ResourceConverterPubsubLiteReservation()},
 		"google_pubsub_lite_subscription":                 {pubsublite.ResourceConverterPubsubLiteSubscription()},
 		"google_pubsub_lite_topic":                        {pubsublite.ResourceConverterPubsubLiteTopic()},

diff --git a/mmv1/third_party/tgc/tests/data/example_secret_manager_secret_iam_policy.json b/mmv1/third_party/tgc/tests/data/example_secret_manager_secret_iam_policy.json
@@ -13,5 +13,24 @@
         }
       ]
     }
+  },
+  {
+    "name": "//secretmanager.googleapis.com/placeholder-rywlkkLJ",
+    "asset_type": "secretmanager.googleapis.com/SecretVersion",
+    "ancestry_path": "{{.Ancestry}}/project/{{.Provider.project}}",
+    "resource": {
+      "version": "v1",
+      "discovery_document_uri": "https://www.googleapis.com/discovery/v1/apis/secretmanager/v1/rest",
+      "discovery_name": "SecretVersion",
+      "parent": "//cloudresourcemanager.googleapis.com/projects/{{.Provider.project}}",
+      "data": {
+        "payload": {
+          "data": "c2VjcmV0LWRhdGE="
+        }
+      }
+    },
+    "ancestors": [
+      "organizations/{{.OrgID}}"
+    ]
   }
-]
+]
diff --git a/mmv1/third_party/tgc/tests/data/example_secret_manager_secret_iam_policy.tf b/mmv1/third_party/tgc/tests/data/example_secret_manager_secret_iam_policy.tf
@@ -46,6 +46,12 @@ resource "google_secret_manager_secret" "secret-basic" {
   }
 }
 
+resource "google_secret_manager_secret_version" "secret-version-basic" {
+  secret = google_secret_manager_secret.secret-basic.id
+
+  secret_data = "secret-data"
+}
+
 resource "google_secret_manager_secret_iam_policy" "policy" {
   project = google_secret_manager_secret.secret-basic.project
   secret_id = google_secret_manager_secret.secret-basic.secret_id